Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

varstash: export the variable for storing stashed vars #52

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Apr 23, 2017

Not sure if this is really smart, but I've added it a while back for zsh-autoenv (Tarrasch/zsh-autoenv@c4e3889).

@daotoad
Copy link
Collaborator

daotoad commented Feb 9, 2018

That's interesting. Is there a use case that this supports?

I'm hesitant because, once it's exported it's part of the interface and someone's will dog will die and they'll get fired if we ever need to take it out.

@cxreg - any thoughts?

@blueyed
Copy link
Contributor Author

blueyed commented Feb 11, 2018

it's part of the interface

I think it's more an issue of security, i.e. exporting makes it available for subcommands, which might possibly leak data.

The reason for doing this was to handle it correctly in subshells (IIRC).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants