Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevicePacker doesn't pack current data after swap when using cudaGraph API #30

Open
cwpearson opened this issue Mar 24, 2021 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@cwpearson
Copy link
Owner

stencil/src/packer.cu

Lines 150 to 158 in 1a4c722

void DevicePacker::pack() {
assert(size_);
#ifdef STENCIL_USE_CUDA_GRAPH
CUDA_RUNTIME(rt::time(cudaSetDevice, domain_->gpu()));
CUDA_RUNTIME(rt::time(cudaGraphLaunch, instance_, stream_));
#else
launch_pack_kernels();
#endif
}

When using CUDA graph, the kernels are recorded with whatever the "current" gridpoint data is.
After a swap, that is wrong, but the replayed kernels will still use it.

@cwpearson cwpearson added the bug Something isn't working label Mar 24, 2021
@cwpearson cwpearson self-assigned this Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant