Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom allocator for DistributedDomain and LocalDomain #2

Open
cwpearson opened this issue Jan 12, 2020 · 1 comment
Open

Allow custom allocator for DistributedDomain and LocalDomain #2

cwpearson opened this issue Jan 12, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@cwpearson
Copy link
Owner

cwpearson commented Jan 12, 2020

To allow for easier testing and extension to future CPU-only stencils, we should define a DeviceAllocator and a ManagedAllocator along the lines of http://www.josuttis.com/cppcode/myalloc.hpp, then, modify XxxDomain to use the allocator.

The new declaration would be like

template<typename Alloc = DeviceAllocator<char>>
class LocalDomain {
...
};

A challenge is that the classes derived from HaloSenders currently have a LocalDomain * member, which means they would have to be templated around both Sender and LocalDomain. They can still derive from HaloSender, though, so the DistributedDomain should be okay.

@cwpearson cwpearson added the enhancement New feature or request label Jan 12, 2020
@cwpearson cwpearson self-assigned this Jan 12, 2020
@cwpearson
Copy link
Owner Author

Allocators were added in 0749943

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant