Error handling on creating property graphs

[Dtenwolde]

Should throw a catalog/Binder exception

• Internal exception when creating property graph on non-existing table #103
• Column of a table does not exist
• FK of a table does not exist
• Primary keys are not unique
• PK of referenced source table does not exist
• PK of referenced destination table does not exist
• FK of source of edge table does not exist
• Multiple PKs are referenced from source/destination table (How would this work?)
• Ensure everything is case insensitive

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[dentiny]

Hi @Dtenwolde , I would like to know more about duckdb and pgq; I'm wondering if you could provide me some code pointers, and if I could take some of the low-priority tickets mentioned in the issue? Thank you!

[Dtenwolde]

Hi @dentiny, thanks for showing interest! This issue is partially outdated, I haven't found the time yet to verify all of the cases above actually have the correct behaviour of throwing an error. In case you want to work on this I would greatly appreciate it!
The code to verify the property graph is here: https://github.com/cwida/duckpgq-extension/blob/main/src/core/functions/table/create_property_graph.cpp.
Relevant test cases are here: https://github.com/cwida/duckpgq-extension/blob/main/test/sql/create_pg
Here are some instructions to run the tests (I use CLion so if you have issues I can help out): https://www.notion.so/duckpgq/Contribution-guide-d4f31c025cb44cb2bb477666cdd9e86f

Alternatively, if you want to work on implementing a new feature I think supporting more graph algorithms would be nice, I have a list here: #132. The list is mostly a guideline, so if you have another algorithm in mind that's not on the list then let me know :)
In case you want to implement a graph algorithm, I'd take a look at how PageRank is implemented: https://github.com/cwida/duckpgq-extension/blob/main/src/core/functions/table/pagerank.cpp and https://github.com/cwida/duckpgq-extension/blob/main/src/core/functions/scalar/pagerank.cpp.
The query builds an on the fly CSR data structure and then uses that as the graph representation for the algorithm.

Let me know what you'd like to work on and reach out if you have any questions! :)

[dentiny]

Thank you so much for your kind word and guidance! I will try to get myself familiar with the proj and see if I could help with the error handling.

[Dtenwolde]

Hi @dentiny I just found an issue that's quite related to this one and should be a good, concrete first issue to work on if you want: #176 :)

[dentiny]

Hi @dentiny I just found an issue that's quite related to this one and should be a good, concrete first issue to work on if you want: #176 :)

Thank you so much for the concrete task and instruction! I will work on it this weekend!