Merge pull request #18 from jalateras/bug/upload-script

fix: syntax error and lint the script
cwida · May 8, 2023 · e3526f3 · e3526f3
2 parents e643a06 + f167b94
commit e3526f3
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/scripts/extension-upload.sh b/scripts/extension-upload.sh
@@ -13,13 +13,12 @@ set -e
 ext="build/release/extension/$1/$1.duckdb_extension"
 
 # compress extension binary
-gzip < $ext > "$1.duckdb_extension.gz"
+gzip < "${ext}" > "$1.duckdb_extension.gz"
 
 # upload compressed extension binary to S3
-aws s3 cp $1.duckdb_extension.gz s3://$5/$1/$2/$3/$4/$1.duckdb_extension.gz --acl public-read
+aws s3 cp "$1.duckdb_extension.gz s3://$5/$1/$2/$3/$4/$1.duckdb_extension.gz" --acl public-read
 
-if [ $6 = 'true']
-then
-  aws s3 cp $1.duckdb_extension.gz s3://$5/$1/latest/$3/$4/$1.duckdb_extension.gz --acl public-read
+# upload to latest if copy_to_latest is set to true
+if [[ $6 = 'true' ]]; then
+  aws s3 cp "$1.duckdb_extension.gz s3://$5/$1/latest/$3/$4/$1.duckdb_extension.gz" --acl public-read
 fi
-# also uplo