Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle bye weeks in matchup string representation #607

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

JasonFreeberg
Copy link
Contributor

If you print a matchup object where there is a bye week, it fails with an error because there is no away team.

This fix assumes that bye weeks will always have a "home team:

If you print a matchup object where there is a bye week, it fails with an error because there is no away team.
@cwendt94
Copy link
Owner

cwendt94 commented Nov 6, 2024

Thanks for fixing this!

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.98%. Comparing base (c41ff3d) to head (16a1c5c).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
espn_api/football/matchup.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #607      +/-   ##
==========================================
- Coverage   84.01%   83.98%   -0.04%     
==========================================
  Files          60       60              
  Lines        2258     2260       +2     
==========================================
+ Hits         1897     1898       +1     
- Misses        361      362       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cwendt94 cwendt94 merged commit 2ca554c into cwendt94:master Nov 6, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants