[2.0.0-beta1] No available patcher was able to apply patch ( for drupal/core ) #521
Closed
5 tasks done
Labels
bug
Inconsistencies or issues which will cause a problem for users or implementors.
Comments
RobinHoutevelts
added
the
bug
|
I'm seeing:
Edit: It seems the culprit is the If I change the depth to Full output of relevant Composer command with the -vvv flag added |
RobinHoutevelts
changed the title
RobinHoutevelts
changed the title
|
Thank you so much for the detailed bug report! This is super helpful!! Will look into this. |
|
If I change the patch file to include the I usually create my patches by deleting the But by doing I was curious how this could have worked all this time in https://github.com/cweagans/composer-patches/blob/1.7.3/src/Patches.php#L396-L407 I won't ask you to reintroduce that logic 😅 Congratulations on the |
RobinHoutevelts
changed the title
|
I think we could probably adjust the defaults to account for that workflow. Using the core sub tree isn't uncommon. |
|
Just hit this with 2.0.0-beta2, not sure if I understand the implications of what was said above. |
In Patches.php line 288: No available patcher was able to apply patch https://www.drupal.org/files/issues/ctools-option_to_expose-2667652-3.patch to drupal/ctools Abandoning 2.0.0-beta2, going back to 1.7.3 |
|
@joejoseph00 Please open an issue and provide all the details requested. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Verification
composer self-update)composer update cweagans/composer-patches)What were you trying to do (and why)?
Trying to upgrade from
1.7.3to2.0.0-beta1to test it out.System
MacOS Ventura 13.4.1
git version 2.41.0
Composer version 2.5.8 2023-06-09 17:13:21
PHP 8.1.20 (cli) (built: Jun 17 2023 06:00:49) (NTS)
I also verified it on another system:
macOS Monterey 12.3
git version 2.30.1 (Apple Git-130)
Composer version 2.5.8 2023-06-09 17:13:21
PHP 8.1.16 (cli) (built: Feb 16 2023 07:22:21) (NTS)
What happened? What did you expect to happen?
I got an error. I expected it to run fine. If I change back to
1.7.3it runs fine.I think this might be related to #423. Things seem to be solved there by running
brew install gpatch.However, I already had
gpatchinstalled and as far as I understand, we no longer usepatchbutgit.Here is the error message I get:
Contents of
composer.json{ "name": "robin/cweagans-issue-423", "type": "project", "require": { "drupal/core": "9.4.15", "cweagans/composer-patches": "2.0.0-beta1" }, "config": { "allow-plugins": { "cweagans/composer-patches": true } }, "extra": { "patches": { "drupal/core": { "#2443351: Ensure that settings can't be serialized by not injecting them / replace stuff with container parameters.": "patches/drupal/core/file_system_serialize_dependencies.patch" } } } }Contents of
patches.lock.json{ "_hash": "586c7bb3c9d40df08adde31f47908815e0bca7c74788cbd22bda8ca09dd81bea", "patches": { "drupal/core": [ { "package": "drupal/core", "description": "#2443351: Ensure that settings can't be serialized by not injecting them / replace stuff with container parameters.", "url": "patches/drupal/core/file_system_serialize_dependencies.patch", "sha256": "5d0486c021afe620170deda52313d3d42df2317fb84e62c6910b12fbe140b01a", "depth": 2, "extra": [] } ] } }Full output of
composer patches-doctorFull output of relevant Composer command with the
-vvvflag addedContents of the patch
patches/drupal/core/file_system_serialize_dependencies.patchThe text was updated successfully, but these errors were encountered: