fix review issue. apache#3882

cvictory · May 16, 2019 · 477d652 · 477d652
1 parent 84c3dde
commit 477d652
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 34 deletions.
diff --git a/dubbo-common/src/main/java/org/apache/dubbo/common/utils/StringUtils.java b/dubbo-common/src/main/java/org/apache/dubbo/common/utils/StringUtils.java
@@ -53,7 +53,7 @@ public final class StringUtils {
     private static final Pattern INT_PATTERN = Pattern.compile("^\\d+$");
     private static final int PAD_LIMIT = 8192;
 
-    protected StringUtils() {
+    private StringUtils() {
     }
 
     /**

diff --git a/dubbo-compatible/src/main/java/com/alibaba/dubbo/common/utils/UrlUtils.java b/dubbo-compatible/src/main/java/com/alibaba/dubbo/common/utils/UrlUtils.java
@@ -24,7 +24,7 @@
 import java.util.stream.Collectors;
 
 /**
- * @author cvictory ON 2019-04-17
+ * 2019-04-17
  */
 @Deprecated
 public class UrlUtils {
@@ -34,7 +34,7 @@ public static URL parseURL(String address, Map<String, String> defaults) {
     }
 
     public static List<URL> parseURLs(String address, Map<String, String> defaults) {
-        return UrlUtils.parseURLs(address, defaults).stream().map(e -> new URL(e)).collect(Collectors.toList());
+        return org.apache.dubbo.common.utils.UrlUtils.parseURLs(address, defaults).stream().map(e -> new URL(e)).collect(Collectors.toList());
     }
 
     public static Map<String, Map<String, String>> convertRegister(Map<String, Map<String, String>> register) {

diff --git a/dubbo-compatible/src/main/java/com/alibaba/dubbo/registry/support/FailbackRegistry.java b/dubbo-compatible/src/main/java/com/alibaba/dubbo/registry/support/FailbackRegistry.java
@@ -24,7 +24,7 @@
 import java.util.stream.Collectors;
 
 /**
- * @author cvictory ON 2019-04-17
+ * 2019-04-17
  */
 @Deprecated
 public abstract class FailbackRegistry implements org.apache.dubbo.registry.Registry, Registry {

diff --git a/.../dubbo-registry-api/src/main/java/org/apache/dubbo/registry/support/FailbackRegistry.java b/.../dubbo-registry-api/src/main/java/org/apache/dubbo/registry/support/FailbackRegistry.java
@@ -206,52 +206,22 @@ private void removeFailedNotified(URL url, NotifyListener listener) {
         }
     }
 
-    /**
-     * remove public modifier.
-     *
-     * @return
-     * @since 2.7.2
-     */
     ConcurrentMap<URL, FailedRegisteredTask> getFailedRegistered() {
         return failedRegistered;
     }
 
-    /**
-     * remove public modifier.
-     *
-     * @return
-     * @since 2.7.2
-     */
     ConcurrentMap<URL, FailedUnregisteredTask> getFailedUnregistered() {
         return failedUnregistered;
     }
 
-    /**
-     * remove public modifier.
-     *
-     * @return
-     * @since 2.7.2
-     */
     ConcurrentMap<Holder, FailedSubscribedTask> getFailedSubscribed() {
         return failedSubscribed;
     }
 
-    /**
-     * remove public modifier.
-     *
-     * @return
-     * @since 2.7.2
-     */
     ConcurrentMap<Holder, FailedUnsubscribedTask> getFailedUnsubscribed() {
         return failedUnsubscribed;
     }
 
-    /**
-     * remove public modifier.
-     *
-     * @return
-     * @since 2.7.2
-     */
     ConcurrentMap<Holder, FailedNotifiedTask> getFailedNotified() {
         return failedNotified;
     }