Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error handling #20

Closed
lorensr opened this issue May 4, 2019 · 2 comments
Closed

Error handling #20

lorensr opened this issue May 4, 2019 · 2 comments
Labels
enhancement Shiny new features or upgrades to old ones

Comments

@lorensr
Copy link
Contributor

lorensr commented May 4, 2019 •
edited
Loading

For example:

https://github.com/apollographql/apollo-server/blob/master/packages/apollo-datasource-rest/src/RESTDataSource.ts#L117-L141

and a method to override:

https://github.com/apollographql/apollo-server/blob/master/packages/apollo-datasource-rest/src/RESTDataSource.ts#L100-L102

(I'm not asking for this feature for myself—just a suggestion for future dev ☺️)
@cvburgess
Copy link
Owner

Interesting idea! Thanks for the ticket

@cvburgess cvburgess added the enhancement Shiny new features or upgrades to old ones label May 6, 2019
@cvburgess
Copy link
Owner

This should be fine with v1, as we are not changing or wrapping knex anymore. Any .catch(_ should suffice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Shiny new features or upgrades to old ones
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lorensr @cvburgess