Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with hanging web application in browser when annotations save is called. #949

Closed
vskubriev opened this issue Dec 13, 2019 · 17 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@vskubriev
Copy link
Contributor

Specifically, with the current task, we had a problem - the interface freezes when saving a frame (frames through autosave). The server is powerful enough and its la is very low. Therefore, I believe that the problem is precisely in the client part of the markup executable in the browser. Apparently, the interface freezes at the time of autosave or manual saving by Ctrl+S. The entire task contains 3.5 thousand frames. Frames can contain up to 80 objects of type polyline. The entire task almost completely marked.

It can also be noted that:

  1. Previously (when marking up images in this task just started): the open menu button and autosave function did not cause web ui hanging.
  2. Also, another task with a small fraction of similarly marked images works without problems.
  3. First pre-main page with LOADING shows a long time compared to other tasks.wed
  4. Saving in another tasks with bounding boxes and smaller frames is running without hanging.

How can I help myself in solving/analyze this problem?

@vskubriev
Copy link
Contributor Author

image

@vskubriev
Copy link
Contributor Author

image

@vskubriev
Copy link
Contributor Author

image

@nmanovic nmanovic added the enhancement New feature or request label Dec 13, 2019
@nmanovic nmanovic added this to the 1.0.0 - Beta milestone Dec 13, 2019
@vskubriev
Copy link
Contributor Author

When is beta 1.0 roughly planned?

@nmanovic
Copy link
Contributor

@vskubriev , we will look in the problem. Could you please provide some parameters of your task? How many annotations do you have and its type? Please post label specification?

@nmanovic
Copy link
Contributor

@vskubriev , we will try to fix the issue till next release but cannot promise.

@nmanovic
Copy link
Contributor

@vskubriev , you are welcome to contribute!

@vskubriev
Copy link
Contributor Author

@vskubriev , we will look in the problem. Could you please provide some parameters of your task? How many annotations do you have and its type? Please post label specification?

Task is about 3.5k images with 1920*1200 pixels. Most of images are marked up.

What do you mean by "its type" - type of objects is polylines.
What do you mean by "label specification" - Where I can find it?

@vskubriev
Copy link
Contributor Author

Latest info from one of out markupers:

When he switched to marking up earlier frames (almost at the very beginning), saving became much faster in the same folder.

@bsekachev
Copy link
Member

@vskubriev

Hi, what chrome version have you used to profile?

@vskubriev
Copy link
Contributor Author

@vskubriev

Hi, what chrome version have you used to profile?

google-chrome-stable:amd64=78.0.3904.108-1 on Ubuntu 18.04 (when i did profiling)

@bsekachev
Copy link
Member

Results for me with a task where 50k polygons
Just Array.includes() is not a bottleneck in my case.
It's quite strange.

Screenshot from 2019-12-24 16-57-40

Anyway, I've found some performance problems here.
PR above should resolve them.

@bsekachev
Copy link
Member

@vskubriev

Please, try the PR.
And let us know if it helps.

@vskubriev
Copy link
Contributor Author

Thank you. We can apply this update only next year. Happy new year.

@bsekachev
Copy link
Member

@vskubriev

Hi, what is the news?

@vskubriev
Copy link
Contributor Author

@bsekachev Sorry for a delay. We has installed cvat (Couple of fixes in "save annotations" #1000) at the end of past year. There are no any issues with hanging. We assume that the problem is fixed.

@bsekachev
Copy link
Member

@vskubriev

Great, let's close this issue in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants