Remove gratuitous non-ASCII characters #7683
Open
+9
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpecLad
requested review from
azhavoro,
bsekachev and
Marishka17
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #7683 +/- ##
===========================================
- Coverage 83.47% 83.41% -0.06%
===========================================
Files 373 373
Lines 39739 39722 -17
Branches 3741 3741
===========================================
- Hits 33171 33135 -36
- Misses 6568 6587 +19
|
In `cvat-ui/src/index.html`, the meta element seems useless (the default is already to index and follow; I'm not even sure `index` and `follow` are valid values). So just remove it entirely.
SpecLad
force-pushed
the
remove-nonascii
branch
from
eb5e954
to
56db7d0
Compare
WalkthroughThe changes in this pull request involve minor modifications across various files, primarily focusing on correcting comments, improving error handling, and refining test case descriptions. Updates include formatting corrections in mathematical expressions and HTML meta tags, as well as enhancements to notification messages and error handling in the notifications reducer. Additionally, several Cypress test files have been updated for consistency in string formatting and clarity in test descriptions. Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (8)
💤 Files with no reviewable changes (1)
✅ Files skipped from review due to trivial changes (6)
🔇 Additional comments (1)cvat-ui/src/reducers/notifications-reducer.ts (1)
The change replaces a non-ASCII curly quote with a standard ASCII straight quote in the message string, which improves cross-platform compatibility and maintainability. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #7683 +/- ##
===========================================
- Coverage 74.31% 74.26% -0.05%
===========================================
Files 401 401
Lines 43421 43421
Branches 3951 3951
===========================================
- Hits 32269 32248 -21
- Misses 11152 11173 +21
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
cvat-ui/src/index.html, the meta element seems useless (the default is already to index and follow; I'm not even sureindexandfolloware valid values). So just remove it entirely.Motivation and context
How has this been tested?
Checklist
developbranch[ ] I have created a changelog fragment[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have linked related issues (see GitHub docs)[ ] I have increased versions of npm packages if it is necessary(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.
Summary by CodeRabbit
Release Notes
Bug Fixes
Chores