Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If there are multiple jobs in one task, delete_frames are saved for each job and the previous data is deleted. #5105

Closed
byeong0 opened this issue Oct 13, 2022 · 3 comments · Fixed by #5138
Assignees
Labels
bug Something isn't working

Comments

@byeong0
Copy link

byeong0 commented Oct 13, 2022

My actions before raising this issue

Expected Behaviour

engine_data.deleted_frames existing data must not be deleted.

Current Behaviour

engine_data.deleted_frames data will be deleted.

If there are multiple jobs in one task,
While deletion frames are managed in task units,
'deleted_frames' seems to load/save on a job

save the job that deleted some frames
If you save another job in the same task,
deleted frame data saved in the previous job is deleted.

Because the engine_job<->engine_task<->engine_data relationship
calls only the 'deleted_frames' of the job, the 'deleted_frames' stored in the task unit is
It seems to disappear because it has been updated to deleted_frame by job unit.

Possible Solution

'deleted_frames' must be saved/loaded on a task basis or the column 'deleted_frames' must be managed on a job basis.

Steps to Reproduce (for bugs)

1.Create multiple jobs in one task
1.Delete and save some frame from the first Job
1.Delete and save some frame from the second Job.
1.Delete frame data for the first Job disappears

Context

Your Environment

  • cvat v2.2.0
@bsekachev
Copy link
Member

@byeong0

Thank you for report. I submit that there is a bug.

@bsekachev bsekachev added the bug Something isn't working label Oct 17, 2022
@bsekachev bsekachev self-assigned this Oct 17, 2022
@bsekachev
Copy link
Member

@byeong0 Please, try the PR above. It should help.

@byeong0
Copy link
Author

byeong0 commented Oct 18, 2022

@byeong0 Please, try the PR above. It should help.

Thank you very much for the quick bug fix. When I tried the PR above, it works well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants