Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

one bug of computing Jobs issues nums #4787

Closed
2 tasks
lyq12580 opened this issue Aug 2, 2022 · 4 comments · Fixed by #5101
Closed
2 tasks

one bug of computing Jobs issues nums #4787

lyq12580 opened this issue Aug 2, 2022 · 4 comments · Fixed by #5101

Comments

@lyq12580
Copy link

lyq12580 commented Aug 2, 2022

My actions before raising this issue

find a bug in "cvat\cvat-ui\src\components\task-page\job-list.tsx"

Expected Behaviour

Current Behaviour

useEffect(() => {
setError(null);
jobInstance
.issues(jobInstance.id)
.then((issues: any[]) => {
setSummary({
issues_unsolved: issues.filter((issue) => !issue.resolved_date).length,
issues_resolved: issues.filter((issue) => issue.resolved_date).length,
});
})
.catch((_error: any) => {
// eslint-disable-next-line
console.log(_error);
setError(_error);
});
}, []);

Possible Solution

useEffect(() => {
setError(null);
jobInstance
.issues(jobInstance.id)
.then((issues: any[]) => {
setSummary({
issues_unsolved: issues.filter((issue) => !issue.resolved).length,
issues_resolved: issues.filter((issue) => issue.resolved).length,
});
})
.catch((_error: any) => {
// eslint-disable-next-line
console.log(_error);
setError(_error);
});
}, []);

Steps to Reproduce (for bugs)

Context

Your Environment

  • Git hash commit (git log -1):
  • Docker version docker version (e.g. Docker 17.0.05):
  • Are you using Docker Swarm or Kubernetes?
  • Operating System and version (e.g. Linux, Windows, MacOS):
  • Code example or link to GitHub repo or gist to reproduce problem:
  • Other diagnostic information / logs:
    Logs from `cvat` container

Next steps

You may join our Gitter channel for community support.

@alex4men
Copy link
Contributor

alex4men commented Oct 7, 2022

@lyq12580 why did you close the issue? Your solution works, but the bug is still in the repo. Could you open the issue, please? I could make a pull request, if you wish.

@nmanovic nmanovic reopened this Oct 9, 2022
@nmanovic
Copy link
Contributor

nmanovic commented Oct 9, 2022

@alex4men , please do! We love contribution.

@lyq12580
Copy link
Author

lyq12580 commented Oct 9, 2022

@lyq12580 why did you close the issue? Your solution works, but the bug is still in the repo. Could you open the issue, please? I could make a pull request, if you wish.

nobody can reply me, so i close it. Now it is already opened

@lyq12580
Copy link
Author

lyq12580 commented Oct 9, 2022

@lyq12580 why did you close the issue? Your solution works, but the bug is still in the repo. Could you open the issue, please? I could make a pull request, if you wish.

please help make a pull request ,Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants