Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand CVAT flexibility by adding more environment variables to cvat/settings/base.py #2362

Closed
2 tasks done
aleksandrmelnikov opened this issue Oct 27, 2020 · 2 comments
Closed
2 tasks done
Labels
enhancement New feature or request

Comments

@aleksandrmelnikov
Copy link
Contributor

My actions before raising this issue

Expected Behaviour

Current Behaviour

Current paths are hard-coded.

SHARE_ROOT = os.path.join(BASE_DIR, 'share')

Possible Solution

SHARE_ROOT = os.path.join(BASE_DIR,os.getenv("CVAT_SHARE_ROOT",'share'))

Steps to Reproduce (for bugs)

Context

We're using CVAT inside a k8s environment.
Overall, it works great.

One issue we're running into is supporting CVAT on a wider range of machine types on Azure.

The main issue is we allow the user to create a volume for "keys", "logs", "data", "models", and so forth.
-We allow volumes to persist the data between pod restarts.
These volumes use up disks, and each machine type on Azure supports only so many disk.

One thing we can do is reduce volumes, and we can do that by putting logs, keys, etc, under one path.

  • And this path would be under one volume

To make this work with CVAT, we can have python pull the path via environment variable, or default to the original setting in CVAT.
Example:

SHARE_ROOT = os.path.join(BASE_DIR,os.getenv("CVAT_SHARE_ROOT",'share'))

Relevant issues:
#445
#1641

Your Environment

  • Git hash commit (git log -1):
  • Docker version docker version (e.g. Docker 17.0.05):
  • Are you using Docker Swarm or Kubernetes?
  • Operating System and version (e.g. Linux, Windows, MacOS):
  • Code example or link to GitHub repo or gist to reproduce problem:
  • Other diagnostic information / logs:
    Logs from `cvat` container

Next steps

You may join our Gitter channel for community support.

@aleksandrmelnikov
Copy link
Contributor Author

We're working on this change and will create a PR for further review.

@nmanovic
Copy link
Contributor

@aleksandrmelnikov , community added some environment variables. Let me know if it isn't enough. Don't hesitate to contribute. I will close the issue as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants