Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling if a job is annotated by several users #191

Closed
3 tasks
nmanovic opened this issue Nov 9, 2018 · 1 comment · Fixed by #389
Closed
3 tasks

Improve error handling if a job is annotated by several users #191

nmanovic opened this issue Nov 9, 2018 · 1 comment · Fixed by #389
Assignees
Labels
enhancement New feature or request

Comments

@nmanovic
Copy link
Contributor

nmanovic commented Nov 9, 2018

Now if a job is modified by several clients in parallel it will lead to an exception on server side (#190). Users complain about such behaviour.

  • It is better to keep a version of annotation inside DB and pass it to client during initialization. When a client wants to save work it will update the version and sent it together with annotations. Thus server will clearly understand that there is a conflict and provide meaningful error message.

  • Also it is good to have "force" flag to override existing annotations in DB explicitly. Thus user will be able to save annotations (delete old and add new).

  • As discussed maybe ID should be unique inside a frame (high part of 64-int should contain frame number, low part of the int should contain a local id). Thus it will be easy to annotate in parallel different frames. But such approach works bad for tracks (users can draw different tracks for one object on different frames).

@nmanovic nmanovic added the enhancement New feature or request label Nov 9, 2018
@nmanovic nmanovic added this to the 0.3.0 - Beta milestone Nov 9, 2018
@nmanovic nmanovic modified the milestones: 0.3.0 - Beta, 0.3.0 - Release Dec 1, 2018
@nmanovic nmanovic modified the milestones: 0.4.0 - Alpha, 0.4.0 - Beta Jan 21, 2019
@nmanovic
Copy link
Contributor Author

nmanovic commented Feb 8, 2019

Andrei Spiridonov poxyu 06:40
Is it possible for several people to annotate same video/image in parallel? I tested it, but got error with status 400. Thank you!

poxyu , it is possible but you need to have several jobs for that (segment_size parameter when you create an annotation task). You got 400 error because we track ids of objects during annotations (aka client_id) and they become inconsistent if several persons annotate the same job. We know about the issue and think how to gracefully solve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants