Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New users (no rights) can view tasks #1030

Closed
rvorias opened this issue Jan 8, 2020 · 7 comments · Fixed by #3788
Closed

New users (no rights) can view tasks #1030

rvorias opened this issue Jan 8, 2020 · 7 comments · Fixed by #3788
Assignees
Labels
bug Something isn't working

Comments

@rvorias
Copy link

rvorias commented Jan 8, 2020

I'm hosting a cvat server and when I create a new user account via the login page, the new user has direct access to the existing tasks: it sees the list of tasks and can even export the annotations.

The documentation says:

You can register a user but by default it will not have rights even to view
list of tasks.

Can someone verify if this is broken? Atm it makes my cvat server unusable.

View from newly made user
Screenshot from 2020-01-08 16-37-06

View from admin panel
Screenshot from 2020-01-08 16-38-15

@rvorias rvorias changed the title New users can view tasks New users (no rights) can view tasks Jan 8, 2020
@bsekachev bsekachev added question Further information is requested and removed question Further information is requested labels Jan 9, 2020
@nmanovic nmanovic added the bug Something isn't working label Jan 9, 2020
@nmanovic nmanovic self-assigned this Jan 9, 2020
@nmanovic nmanovic added this to the 1.0.0 - Beta milestone Jan 9, 2020
@Panda2Chang
Copy link

I modify https://github.com/opencv/cvat/blob/develop/cvat/apps/authentication/auth.py#L196
to :

  • def has_permission(self, request, view):
  •    return request.user.has_perm("engine.task.access")
    

It work,but I do not know have any side-effect for this moodify

@anderflash
Copy link

Hi,
Related to this issue, an annotator can't be allowed to see the "Create Task" button and can't have access to the 'create task' screen, since it shows the complete server share (by clicking on its tab) with all the images, a security issue.

@BlueNotesRobot
Copy link

I figured new users can see all tasks which have not yet been assigned. To deal with that I created a new user called "unassigned".
Whenever I create a new task, I assign it to that user and then new users cannot see it.

@azhavoro
Copy link
Contributor

At the moment as workaround is possible to set reduce_task_visibility variable to True here https://github.com/opencv/cvat/blob/develop/cvat/settings/base.py#L424 to remove public access to unassigned tasks. The new permission system will be introduced in future releases.

@nmanovic nmanovic modified the milestones: 1.1.0-beta, 1.2.0-beta Jul 29, 2020
@nmanovic nmanovic modified the milestones: 1.2.0-beta, 1.3.0-beta Dec 15, 2020
@nmanovic nmanovic removed this from the 1.3.0-beta milestone Mar 8, 2021
@leeyh20
Copy link

leeyh20 commented Apr 22, 2021

Hi would like to know when the permission system will be introduced? :)

@omersefaztrk
Copy link

@azhavoro I tried your advice. But it does not work. I set reduce_task_visibility variable as True and ı build cvat with docker-compose up -d. :(

@Crescent-Saturn
Copy link
Contributor

@omersefaztrk , since you modify the source code, you need to build the CVAT with docker-compose.dev.yml file.
You can refer to this #1283 for more details, especially this reply, good luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants