Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not sure license can be MIT #44

Open
diegoceccarelli opened this issue Jun 13, 2023 · 3 comments
Open

Not sure license can be MIT #44

diegoceccarelli opened this issue Jun 13, 2023 · 3 comments

Comments

@diegoceccarelli
Copy link

The License in pytrec_eval is MIT but the repo includes https://github.com/usnistgov/trec_eval/tree/de6a29f8ba9312c73f978aa9739695aa8ebf48eb that is under the copyright of Chris Buckley
see also https://github.com/usnistgov/trec_eval/blob/master/convert_zscores.c#L2-L5
and usnistgov/trec_eval#10

@dmlls
Copy link

dmlls commented Jul 28, 2023

This could also have repercussions for BEIR, which includes pytrec_eval as a core dependency, and is licensed under Apache 2.0.

@seanmacavaney
Copy link
Contributor

It looks like the license was added in b8358d4. cc: @cvangysel

@cvangysel
Copy link
Owner

cvangysel commented Aug 22, 2023

Thanks all. My apologies for the delayed response. We're in the process of transferring ownership of this repository to the Amsterdam IRLab and so hopefully the future maintainers will have a better response turnaround time.

I'm not a lawyer, but my understanding is that trec_eval is a transitive dependency of pytrec_eval. The MIT license applies only to the source code present in this repository, and not the trec_eval source code itself (since I have no control over that). The fact that trec_eval uses a different license from pytrec_eval is mentioned in the README: https://github.com/cvangysel/pytrec_eval#license.

We are not redistributing the trec_eval code (either source or compiled) as part of the published Python package, since that triggers this code path and pulls in the trec_eval source code at installation time. However, that may not be the case for the binary distributions published in the Terrier fork which is maintained by a 3rd party.

The license linked by @diegoceccarelli allows for non-commercial, research usage/modification and applies to trec_eval as well. Hence, if you are allowed to use trec_eval as a tool, you are also allowed to use pytrec_eval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants