Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Request game list on socket reconnect #1012

Open
itsalaidbacklife opened this issue Sep 1, 2024 · 0 comments · May be fixed by #1074
Open

[Feature]: Request game list on socket reconnect #1012

itsalaidbacklife opened this issue Sep 1, 2024 · 0 comments · May be fixed by #1074
Labels
enhancement New feature or request frontend Requires changes to the frontend (vue) client good first issue Good for newcomers version-patch An update that warrants a bumping the project's patch version (e.g. 4.0.0 => 4.0.1)

Comments

@itsalaidbacklife
Copy link
Contributor

Feature Summary

When the socket disconnects and reconnects, we should request the latest list of available games to populate the homepage

Detailed Description

We already have logic in place to update state when the socket connects; we should simply update this to accommodate the case where it happens on the homepage.

we should update src/plugins/sockets/connectivityEvents.js to handle the case where the route is ROUTE_NAME_HOME, and in that case, request the game list with gameListStore.requestGameList()

This will require importing and instantiating the gameList store in the same fashion as the other stores in this file

@itsalaidbacklife itsalaidbacklife added enhancement New feature or request good first issue Good for newcomers version-patch An update that warrants a bumping the project's patch version (e.g. 4.0.0 => 4.0.1) frontend Requires changes to the frontend (vue) client labels Sep 1, 2024
@Mang0codes Mang0codes linked a pull request Oct 4, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Requires changes to the frontend (vue) client good first issue Good for newcomers version-patch An update that warrants a bumping the project's patch version (e.g. 4.0.0 => 4.0.1)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant