Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs for rounded corners (example code not matching screenshot) #156

Open
bcutter opened this issue Dec 9, 2022 · 4 comments
Open

Comments

@bcutter
Copy link

bcutter commented Dec 9, 2022

https://github.com/custom-cards/bar-card#200-default-layout-requires-card-mod shows rounded corners, while the example code is not working.

According to #137 one needs to add

style: |-
  bar-card-currentbar, bar-card-backgroundbar {
    border-radius: 4px;
  }

Please FIX the docs so other users don't run into this issue.

Details: #137 (comment)

bcutter referenced this issue Dec 9, 2022
border-radius as shown in screen was missing in example code
@ButterBetzi
Copy link

Hi,
Im trying to round my corners in the same way you did in the screenshot and with this docu pr. But its not rounding for me. Could you confirm if this still works for you today?

@bcutter
Copy link
Author

bcutter commented Jan 6, 2024

Hi, Im trying to round my corners in the same way you did in the screenshot and with this docu pr. But its not rounding for me. Could you confirm if this still works for you today?

Yes working still quite well for me - but my HA Core Frontend is version 20230411.1 - maybe meanwhile few changes have been introduced.

@ButterBetzi
Copy link

Thanks for the quick answer!
Ah, ok, that might be it. Im running the latest version and cannot get those dawn corners rounded :D
But this seems to be my problem as I saw that this repo isnt maintained since 2020

@bcutter
Copy link
Author

bcutter commented Jan 6, 2024

Well, not officially unmaintained (no notice), but yeah 10 open PRs, nobody seems to take care...

@jackjohnsonuk @Gluwc do you have write access to merge PRs and can ideally elaborate on the current status of this repo please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants