-
Notifications
You must be signed in to change notification settings - Fork 0
/
.semgrep_rules.yml
14573 lines (14573 loc) · 520 KB
/
.semgrep_rules.yml
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
rules:
- id: python.lang.security.audit.dangerous-os-exec.dangerous-os-exec
languages:
- python
message: Found dynamic content when spawning a process. This is dangerous if external
data can reach this function call because it allows a malicious actor to execute
commands. Ensure no external data reaches here.
metadata:
asvs:
control_id: 5.3.8 OS Command Injection
control_url: https://github.com/OWASP/ASVS/blob/master/4.0/en/0x13-V5-Validation-Sanitization-Encoding.md#v53-output-encoding-and-injection-prevention-requirements
section: 'V5: Validation, Sanitization and Encoding Verification Requirements'
version: '4'
category: security
cwe: 'CWE-78: Improper Neutralization of Special Elements used in an OS Command
(''OS Command Injection'')'
license: Commons Clause License Condition v1.0[LGPL-2.1-only]
owasp: 'A1: Injection'
shortlink: https://sg.run/L8BX
source: https://semgrep.dev/r/python.lang.security.audit.dangerous-os-exec.dangerous-os-exec
technology:
- python
pattern-either:
- patterns:
- pattern-not: os.$METHOD("...", ...)
- pattern: os.$METHOD(...)
- metavariable-regex:
metavariable: $METHOD
regex: (execl|execle|execlp|execlpe|execv|execve|execvp|execvpe)
- patterns:
- pattern-not: os.$METHOD("...", [$PATH,"...","...",...],...)
- pattern: os.$METHOD($BASH,[$PATH,"-c",$CMD,...],...)
- metavariable-regex:
metavariable: $METHOD
regex: (execv|execve|execvp|execvpe)
- metavariable-regex:
metavariable: $BASH
regex: (.*)(sh|bash|ksh|csh|tcsh|zsh)
- patterns:
- pattern-not: os.$METHOD("...", $PATH, "...", "...",...)
- pattern: os.$METHOD($BASH, $PATH, "-c", $CMD,...)
- metavariable-regex:
metavariable: $METHOD
regex: (execl|execle|execlp|execlpe)
- metavariable-regex:
metavariable: $BASH
regex: (.*)(sh|bash|ksh|csh|tcsh|zsh)
severity: ERROR
- id: python.lang.security.audit.dangerous-spawn-process.dangerous-spawn-process
languages:
- python
message: Found dynamic content when spawning a process. This is dangerous if external
data can reach this function call because it allows a malicious actor to execute
commands. Ensure no external data reaches here.
metadata:
asvs:
control_id: 5.3.8 OS Command Injection
control_url: https://github.com/OWASP/ASVS/blob/master/4.0/en/0x13-V5-Validation-Sanitization-Encoding.md#v53-output-encoding-and-injection-prevention-requirements
section: 'V5: Validation, Sanitization and Encoding Verification Requirements'
version: '4'
category: security
cwe: 'CWE-78: Improper Neutralization of Special Elements used in an OS Command
(''OS Command Injection'')'
license: Commons Clause License Condition v1.0[LGPL-2.1-only]
owasp: 'A1: Injection'
shortlink: https://sg.run/OPYB
source: https://semgrep.dev/r/python.lang.security.audit.dangerous-spawn-process.dangerous-spawn-process
source-rule-url: https://bandit.readthedocs.io/en/latest/plugins/b605_start_process_with_a_shell.html
technology:
- python
pattern-either:
- patterns:
- pattern-not: os.$METHOD($MODE, "...", ...)
- pattern: os.$METHOD(...)
- metavariable-regex:
metavariable: $METHOD
regex: (spawnl|spawnle|spawnlp|spawnlpe|spawnv|spawnve|spawnvp|spawnvp|spawnvpe|posix_spawn|posix_spawnp|startfile)
- patterns:
- pattern-not: os.$METHOD($MODE, "...", ["...","...",...], ...)
- pattern: os.$METHOD($MODE, $BASH, ["-c",$CMD,...],...)
- metavariable-regex:
metavariable: $METHOD
regex: (spawnv|spawnve|spawnvp|spawnvp|spawnvpe|posix_spawn|posix_spawnp)
- metavariable-regex:
metavariable: $BASH
regex: (.*)(sh|bash|ksh|csh|tcsh|zsh)
- patterns:
- pattern-not: os.$METHOD($MODE, "...", "...", "...", ...)
- pattern: os.$METHOD($MODE, $BASH, "-c", $CMD,...)
- metavariable-regex:
metavariable: $METHOD
regex: (spawnl|spawnle|spawnlp|spawnlpe)
- metavariable-regex:
metavariable: $BASH
regex: (.*)(sh|bash|ksh|csh|tcsh|zsh)
severity: ERROR
- id: python.django.performance.access-foreign-keys.access-foreign-keys
languages:
- python
message: You should use ITEM.user_id rather than ITEM.user.id to prevent running
an extra query.
metadata:
category: performance
license: Commons Clause License Condition v1.0[LGPL-2.1-only]
shortlink: https://sg.run/XBoB
source: https://semgrep.dev/r/python.django.performance.access-foreign-keys.access-foreign-keys
technology:
- django
patterns:
- pattern-either:
- pattern-inside: |
from django.$Y import $Z
...
- pattern-inside: |
import django
...
- pattern: $X.user.id
- pattern-not: request.user.id
severity: WARNING
- id: python.django.security.injection.command.command-injection-os-system.command-injection-os-system
languages:
- python
message: Request data detected in os.system. This could be vulnerable to a command
injection and should be avoided. If this must be done, use the 'subprocess' module
instead and pass the arguments as a list. See https://owasp.org/www-community/attacks/Command_Injection
for more information.
metadata:
category: security
cwe: 'CWE-78: Improper Neutralization of Special Elements used in an OS Command
(''OS Command Injection'')'
license: Commons Clause License Condition v1.0[LGPL-2.1-only]
owasp: 'A1: Injection'
references:
- https://owasp.org/www-community/attacks/Command_Injection
shortlink: https://sg.run/Gen2
source: https://semgrep.dev/r/python.django.security.injection.command.command-injection-os-system.command-injection-os-system
technology:
- django
patterns:
- pattern-inside: |
def $FUNC(...):
...
- pattern-either:
- pattern: os.system(..., request.$W.get(...), ...)
- pattern: os.system(..., $S.format(..., request.$W.get(...), ...), ...)
- pattern: os.system(..., $S % request.$W.get(...), ...)
- pattern: os.system(..., f"...{request.$W.get(...)}...", ...)
- pattern: |
$DATA = request.$W.get(...)
...
os.system(..., $DATA, ...)
- pattern: |
$DATA = request.$W.get(...)
...
$INTERM = $DATA
...
os.system(..., $INTERM, ...)
- pattern: |
$DATA = request.$W.get(...)
...
os.system(..., $STR.format(..., $DATA, ...), ...)
- pattern: |
$DATA = request.$W.get(...)
...
$INTERM = $STR.format(..., $DATA, ...)
...
os.system(..., $INTERM, ...)
- pattern: |
$DATA = request.$W.get(...)
...
os.system(..., $STR % $DATA, ...)
- pattern: |
$DATA = request.$W.get(...)
...
$INTERM = $STR % $DATA
...
os.system(..., $INTERM, ...)
- pattern: |
$DATA = request.$W.get(...)
...
os.system(..., f"...{$DATA}...", ...)
- pattern: |
$DATA = request.$W.get(...)
...
$INTERM = f"...{$DATA}..."
...
os.system(..., $INTERM, ...)
- pattern: |
$DATA = request.$W.get(...)
...
os.system(..., $STR + $DATA, ...)
- pattern: |
$DATA = request.$W.get(...)
...
$INTERM = $STR + $DATA
...
os.system(..., $INTERM, ...)
- pattern: $A = os.system(..., request.$W.get(...), ...)
- pattern: $A = os.system(..., $S.format(..., request.$W.get(...), ...), ...)
- pattern: $A = os.system(..., $S % request.$W.get(...), ...)
- pattern: $A = os.system(..., f"...{request.$W.get(...)}...", ...)
- pattern: return os.system(..., request.$W.get(...), ...)
- pattern: return os.system(..., $S.format(..., request.$W.get(...), ...), ...)
- pattern: return os.system(..., $S % request.$W.get(...), ...)
- pattern: return os.system(..., f"...{request.$W.get(...)}...", ...)
- pattern: os.system(..., request.$W(...), ...)
- pattern: os.system(..., $S.format(..., request.$W(...), ...), ...)
- pattern: os.system(..., $S % request.$W(...), ...)
- pattern: os.system(..., f"...{request.$W(...)}...", ...)
- pattern: |
$DATA = request.$W(...)
...
os.system(..., $DATA, ...)
- pattern: |
$DATA = request.$W(...)
...
$INTERM = $DATA
...
os.system(..., $INTERM, ...)
- pattern: |
$DATA = request.$W(...)
...
os.system(..., $STR.format(..., $DATA, ...), ...)
- pattern: |
$DATA = request.$W(...)
...
$INTERM = $STR.format(..., $DATA, ...)
...
os.system(..., $INTERM, ...)
- pattern: |
$DATA = request.$W(...)
...
os.system(..., $STR % $DATA, ...)
- pattern: |
$DATA = request.$W(...)
...
$INTERM = $STR % $DATA
...
os.system(..., $INTERM, ...)
- pattern: |
$DATA = request.$W(...)
...
os.system(..., f"...{$DATA}...", ...)
- pattern: |
$DATA = request.$W(...)
...
$INTERM = f"...{$DATA}..."
...
os.system(..., $INTERM, ...)
- pattern: |
$DATA = request.$W(...)
...
os.system(..., $STR + $DATA, ...)
- pattern: |
$DATA = request.$W(...)
...
$INTERM = $STR + $DATA
...
os.system(..., $INTERM, ...)
- pattern: $A = os.system(..., request.$W(...), ...)
- pattern: $A = os.system(..., $S.format(..., request.$W(...), ...), ...)
- pattern: $A = os.system(..., $S % request.$W(...), ...)
- pattern: $A = os.system(..., f"...{request.$W(...)}...", ...)
- pattern: return os.system(..., request.$W(...), ...)
- pattern: return os.system(..., $S.format(..., request.$W(...), ...), ...)
- pattern: return os.system(..., $S % request.$W(...), ...)
- pattern: return os.system(..., f"...{request.$W(...)}...", ...)
- pattern: os.system(..., request.$W[...], ...)
- pattern: os.system(..., $S.format(..., request.$W[...], ...), ...)
- pattern: os.system(..., $S % request.$W[...], ...)
- pattern: os.system(..., f"...{request.$W[...]}...", ...)
- pattern: |
$DATA = request.$W[...]
...
os.system(..., $DATA, ...)
- pattern: |
$DATA = request.$W[...]
...
$INTERM = $DATA
...
os.system(..., $INTERM, ...)
- pattern: |
$DATA = request.$W[...]
...
os.system(..., $STR.format(..., $DATA, ...), ...)
- pattern: |
$DATA = request.$W[...]
...
$INTERM = $STR.format(..., $DATA, ...)
...
os.system(..., $INTERM, ...)
- pattern: |
$DATA = request.$W[...]
...
os.system(..., $STR % $DATA, ...)
- pattern: |
$DATA = request.$W[...]
...
$INTERM = $STR % $DATA
...
os.system(..., $INTERM, ...)
- pattern: |
$DATA = request.$W[...]
...
os.system(..., f"...{$DATA}...", ...)
- pattern: |
$DATA = request.$W[...]
...
$INTERM = f"...{$DATA}..."
...
os.system(..., $INTERM, ...)
- pattern: |
$DATA = request.$W[...]
...
os.system(..., $STR + $DATA, ...)
- pattern: |
$DATA = request.$W[...]
...
$INTERM = $STR + $DATA
...
os.system(..., $INTERM, ...)
- pattern: $A = os.system(..., request.$W[...], ...)
- pattern: $A = os.system(..., $S.format(..., request.$W[...], ...), ...)
- pattern: $A = os.system(..., $S % request.$W[...], ...)
- pattern: $A = os.system(..., f"...{request.$W[...]}...", ...)
- pattern: return os.system(..., request.$W[...], ...)
- pattern: return os.system(..., $S.format(..., request.$W[...], ...), ...)
- pattern: return os.system(..., $S % request.$W[...], ...)
- pattern: return os.system(..., f"...{request.$W[...]}...", ...)
- pattern: os.system(..., request.$W, ...)
- pattern: os.system(..., $S.format(..., request.$W, ...), ...)
- pattern: os.system(..., $S % request.$W, ...)
- pattern: os.system(..., f"...{request.$W}...", ...)
- pattern: |
$DATA = request.$W
...
os.system(..., $DATA, ...)
- pattern: |
$DATA = request.$W
...
$INTERM = $DATA
...
os.system(..., $INTERM, ...)
- pattern: |
$DATA = request.$W
...
os.system(..., $STR.format(..., $DATA, ...), ...)
- pattern: |
$DATA = request.$W
...
$INTERM = $STR.format(..., $DATA, ...)
...
os.system(..., $INTERM, ...)
- pattern: |
$DATA = request.$W
...
os.system(..., $STR % $DATA, ...)
- pattern: |
$DATA = request.$W
...
$INTERM = $STR % $DATA
...
os.system(..., $INTERM, ...)
- pattern: |
$DATA = request.$W
...
os.system(..., f"...{$DATA}...", ...)
- pattern: |
$DATA = request.$W
...
$INTERM = f"...{$DATA}..."
...
os.system(..., $INTERM, ...)
- pattern: |
$DATA = request.$W
...
os.system(..., $STR + $DATA, ...)
- pattern: |
$DATA = request.$W
...
$INTERM = $STR + $DATA
...
os.system(..., $INTERM, ...)
- pattern: $A = os.system(..., request.$W, ...)
- pattern: $A = os.system(..., $S.format(..., request.$W, ...), ...)
- pattern: $A = os.system(..., $S % request.$W, ...)
- pattern: $A = os.system(..., f"...{request.$W}...", ...)
- pattern: return os.system(..., request.$W, ...)
- pattern: return os.system(..., $S.format(..., request.$W, ...), ...)
- pattern: return os.system(..., $S % request.$W, ...)
- pattern: return os.system(..., f"...{request.$W}...", ...)
severity: ERROR
- id: python.django.security.audit.avoid-insecure-deserialization.avoid-insecure-deserialization
languages:
- python
message: Avoid using insecure deserialization library, backed by `pickle`, `_pickle`,
`cpickle`, `dill`, `shelve`, or `yaml`, which are known to lead to remote code
execution vulnerabilities.
metadata:
category: security
cwe: 'CWE-502: Deserialization of Untrusted Data'
license: Commons Clause License Condition v1.0[LGPL-2.1-only]
owasp: 'A8: Insecure Deserialization'
references:
- https://docs.python.org/3/library/pickle.html
shortlink: https://sg.run/9oyr
source: https://semgrep.dev/r/python.django.security.audit.avoid-insecure-deserialization.avoid-insecure-deserialization
technology:
- django
mode: taint
pattern-sinks:
- pattern-either:
- patterns:
- pattern-either:
- pattern: |
pickle.$PICKLEFUNC(...)
- pattern: |
_pickle.$PICKLEFUNC(...)
- pattern: |
cPickle.$PICKLEFUNC(...)
- pattern: |
shelve.$PICKLEFUNC(...)
- metavariable-regex:
metavariable: $PICKLEFUNC
regex: dumps|dump|load|loads
- patterns:
- pattern: dill.$DILLFUNC(...)
- metavariable-regex:
metavariable: $DILLFUNC
regex: dump|dump_session|dumps|load|load_session|loads
- patterns:
- pattern: yaml.$YAMLFUNC(...)
- metavariable-regex:
metavariable: $YAMLFUNC
regex: dump|dump_all|load|load_all
pattern-sources:
- pattern-either:
- patterns:
- pattern-inside: |
def $INSIDE(..., $PARAM, ...):
...
- pattern-either:
- pattern: request.$REQFUNC(...)
- pattern: request.$REQFUNC.get(...)
- pattern: request.$REQFUNC[...]
severity: ERROR
- id: python.bokeh.maintainability.deprecated.deprecated_apis.bokeh-deprecated-apis
languages:
- python
message: These APIs are deprecated in Bokeh see https://docs.bokeh.org/en/latest/docs/releases.html#api-deprecations
metadata:
category: maintainability
license: Commons Clause License Condition v1.0[LGPL-2.1-only]
shortlink: https://sg.run/7ok2
source: https://semgrep.dev/r/python.bokeh.maintainability.deprecated.deprecated_apis.bokeh-deprecated-apis
technology:
- bokeh
pattern-either:
- pattern: |
import bokeh.layouts.widgetbox
- pattern: |
import bokeh.models.graphs.from_networkx
severity: WARNING
- id: python.click.best-practice.echo-style.use-click-secho
languages:
- python
message: Use `click.secho($X)` instead. It combines click.echo() and click.style().
metadata:
category: best-practice
license: Commons Clause License Condition v1.0[LGPL-2.1-only]
shortlink: https://sg.run/8ywN
source: https://semgrep.dev/r/python.click.best-practice.echo-style.use-click-secho
technology:
- click
pattern: click.echo(click.style($X, ...))
severity: ERROR
- id: python.django.best-practice.upsell_django_environ.use-django-environ
languages:
- python
message: You are using environment variables inside django app. Use `django-environ`
as it a better alternative for deployment.
metadata:
category: best-practice
license: Commons Clause License Condition v1.0[LGPL-2.1-only]
shortlink: https://sg.run/DoQP
source: https://semgrep.dev/r/python.django.best-practice.upsell_django_environ.use-django-environ
technology:
- django
patterns:
- pattern-not-inside: |
import environ
...
- pattern-either:
- pattern: |
import django
...
import os
...
$FOO = $M.environ[...]
- pattern: |
import os
...
import django
...
$FOO = $M.environ[...]
severity: ERROR
- id: python.django.compatibility.django-2_0-compat.django-compat-2_0-signals-weak
languages:
- python
message: The weak argument to django.dispatch.signals.Signal.disconnect() is removed
in Django 2.0.
metadata:
category: compatibility
license: Commons Clause License Condition v1.0[LGPL-2.1-only]
shortlink: https://sg.run/0Qjj
source: https://semgrep.dev/r/python.django.compatibility.django-2_0-compat.django-compat-2_0-signals-weak
technology:
- django
pattern: django.dispatch.signals.Signal.disconnect(..., weak=$X, ...)
severity: WARNING
- id: python.django.compatibility.django-2_0-compat.django-compat-2_0-extra-forms
languages:
- python
message: The django.forms.extras package is removed in Django 2.0.
metadata:
category: compatibility
license: Commons Clause License Condition v1.0[LGPL-2.1-only]
shortlink: https://sg.run/qx07
source: https://semgrep.dev/r/python.django.compatibility.django-2_0-compat.django-compat-2_0-extra-forms
technology:
- django
pattern-either:
- pattern: from django.forms import extras
- pattern: from django.forms.extras import $X
- pattern: from django.forms import extras as $Y
- pattern: from django.forms.extras import $X as $Y
- pattern: import django.forms.extras
- pattern: import django.forms.extras.$X
- pattern: import django.forms.extras as $Y
- pattern: import django.forms.extras.$X as $Y
severity: WARNING
- id: python.django.compatibility.django-2_0-compat.django-compat-2_0-assignment-tag
languages:
- python
message: The assignment_tag helper is removed in Django 2.0.
metadata:
category: compatibility
license: Commons Clause License Condition v1.0[LGPL-2.1-only]
shortlink: https://sg.run/l2RE
source: https://semgrep.dev/r/python.django.compatibility.django-2_0-compat.django-compat-2_0-assignment-tag
technology:
- django
pattern-either:
- pattern: $X.assignment_tag(...)
- pattern: assignment_tag(...)
severity: WARNING
- id: python.django.compatibility.django-2_0-compat.django-compat-2_0-assert-redirects-helper
languages:
- python
message: The host argument to assertRedirects is removed in Django 2.0.
metadata:
category: compatibility
license: Commons Clause License Condition v1.0[LGPL-2.1-only]
shortlink: https://sg.run/YvQy
source: https://semgrep.dev/r/python.django.compatibility.django-2_0-compat.django-compat-2_0-assert-redirects-helper
technology:
- django
pattern-either:
- pattern: $X.assertRedirects(..., host=$Y, ...)
- pattern: assertRedirects(..., host=$Y, ...)
severity: WARNING
- id: python.django.correctness.model-save.django-db-model-save-super
languages:
- python
message: Detected a django model `$MODEL` is not calling super().save() inside of
the save method.
metadata:
category: correctness
license: Commons Clause License Condition v1.0[LGPL-2.1-only]
shortlink: https://sg.run/6nN1
source: https://semgrep.dev/r/python.django.correctness.model-save.django-db-model-save-super
technology:
- django
patterns:
- pattern-inside: |
class $MODEL(django.db.models.Model):
...
- pattern-not: |
def save(self, ...):
...
super($MODEL, self).save(...)
- pattern-not: |
def save(self, ...):
...
super().save(...)
- pattern: |
def save(self, ...):
...
severity: WARNING
- id: python.django.correctness.string-field-null-checks.string-field-must-set-null-true
languages:
- python
message: If a text field declares unique=True and blank=True, null=True must also
be set to avoid unique constraint violations when saving multiple objects with
blank values.
metadata:
category: correctness
license: Commons Clause License Condition v1.0[LGPL-2.1-only]
shortlink: https://sg.run/pxPZ
source: https://semgrep.dev/r/python.django.correctness.string-field-null-checks.string-field-must-set-null-true
technology:
- django
patterns:
- pattern-inside: |
class $M(...):
...
- pattern-not: $F = django.db.models.CharField(..., unique=True, blank=True, null=True,
...)
- pattern-not: $F = django.db.models.TextField(..., unique=True, blank=True, null=True,
...)
- pattern-either:
- pattern: $F = django.db.models.CharField(..., unique=True, blank=True, ...)
- pattern: $F = django.db.models.TextField(..., unique=True, blank=True, ...)
severity: ERROR
- id: python.django.correctness.use-decimalfield-for-money.use-decimalfield-for-money
languages:
- python
message: Found a FloatField used for variable $F. Use DecimalField for currency
fields to avoid float-rounding errors.
metadata:
category: correctness
license: Commons Clause License Condition v1.0[LGPL-2.1-only]
shortlink: https://sg.run/2xzL
source: https://semgrep.dev/r/python.django.correctness.use-decimalfield-for-money.use-decimalfield-for-money
technology:
- django
patterns:
- pattern-inside: |
class $M(...):
...
- pattern: $F = django.db.models.FloatField(...)
- metavariable-regex:
metavariable: $F
regex: .*([pP][rR][iI][cC][eE]|[aA][mM][oO][uU][nN][tT]|[sS][uU][bB][tT][oO][tT][aA][lL]|[dD][oO][nN][aA][tT][iI][oO][nN]|[fF][eE][eE]|[sS][aA][lL][aA][rR][yY]|[pP][rR][eE][cC][iI][oO]).*
severity: ERROR
- id: python.django.performance.upsell-count.use-count-method
languages:
- python
message: Looks like you need to determine the number of records. Django provides
the count() method which is more efficient than .len(). See https://docs.djangoproject.com/en/3.0/ref/models/querysets/
metadata:
category: performance
license: Commons Clause License Condition v1.0[LGPL-2.1-only]
shortlink: https://sg.run/jRdN
source: https://semgrep.dev/r/python.django.performance.upsell-count.use-count-method
technology:
- django
pattern-either:
- pattern: $X.objects.$FUNC(...).len()
- pattern: $X.objects.$FUNC(...).$FILTER().len()
- pattern: $X.objects.$FUNC(...).$FILTER().$UPDATE(...).len()
severity: ERROR
- id: python.django.performance.upsell_earliest_latest.use-earliest-or-latest
languages:
- python
message: Looks like you are only accessing first element of an ordered QuerySet.
Use `latest()` or `earliest()` instead. See https://docs.djangoproject.com/en/3.0/ref/models/querysets/#django.db.models.query.QuerySet.latest
metadata:
category: performance
license: Commons Clause License Condition v1.0[LGPL-2.1-only]
shortlink: https://sg.run/1ZoG
source: https://semgrep.dev/r/python.django.performance.upsell_earliest_latest.use-earliest-or-latest
technology:
- django
pattern-either:
- pattern: $X.objects.order_by(...)[0]
- pattern: $X.objects.$FUNC(...).order_by(...)[0]
- pattern: $X.objects.$FUNC(...).$FILTER(...).order_by(...)[0]
severity: ERROR
- id: python.django.security.audit.query-set-extra.avoid-query-set-extra
languages:
- python
message: QuerySet.extra' does not provide safeguards against SQL injection and requires
very careful use. SQL injection can lead to critical data being stolen by attackers.
Instead of using '.extra', use the Django ORM and parameterized queries such as
`People.objects.get(name='Bob')`.
metadata:
category: security
cwe: 'CWE-89: Improper Neutralization of Special Elements used in an SQL Command
(''SQL Injection'')'
license: Commons Clause License Condition v1.0[LGPL-2.1-only]
owasp:
- A01:2017 - Injection
- A03:2021 - Injection
references:
- https://docs.djangoproject.com/en/3.0/ref/models/querysets/#django.db.models.query.QuerySet.extra
- https://blog.r2c.dev/2020/preventing-sql-injection-a-django-authors-perspective/
shortlink: https://sg.run/kXZP
source: https://semgrep.dev/r/python.django.security.audit.query-set-extra.avoid-query-set-extra
source-rule-url: https://bandit.readthedocs.io/en/latest/plugins/b610_django_extra_used.html
technology:
- django
patterns:
- pattern: $MODEL.extra(...)
- pattern-not-inside: '$MODEL.extra(select = {$KEY: "..."})'
severity: WARNING
- id: python.django.security.injection.path-traversal.path-traversal-open.path-traversal-open
languages:
- python
message: Found request data in a call to 'open'. Ensure the request data is validated
or sanitized, otherwise it could result in path traversal attacks and therefore
sensitive data being leaked. To mitigate, consider using os.path.abspath or os.path.realpath
or the pathlib library.
metadata:
category: security
cwe: 'CWE-22: Improper Limitation of a Pathname to a Restricted Directory (''Path
Traversal'')'
license: Commons Clause License Condition v1.0[LGPL-2.1-only]
owasp: 'A1: Injection'
references:
- https://owasp.org/www-community/attacks/Path_Traversal
shortlink: https://sg.run/W8qg
source: https://semgrep.dev/r/python.django.security.injection.path-traversal.path-traversal-open.path-traversal-open
technology:
- django
patterns:
- pattern-inside: |
def $FUNC(...):
...
- pattern-either:
- pattern: open(..., request.$W.get(...), ...)
- pattern: open(..., $S.format(..., request.$W.get(...), ...), ...)
- pattern: open(..., $S % request.$W.get(...), ...)
- pattern: open(..., f"...{request.$W.get(...)}...", ...)
- pattern: |
$DATA = request.$W.get(...)
...
open(..., $DATA, ...)
- pattern: |
$DATA = request.$W.get(...)
...
$INTERM = $DATA
...
open(..., $INTERM, ...)
- pattern: |
$DATA = request.$W.get(...)
...
$INTERM = $DATA
...
with open(..., $INTERM, ...) as $FD:
...
- pattern: |
$DATA = request.$W.get(...)
...
open(..., $STR.format(..., $DATA, ...), ...)
- pattern: |
$DATA = request.$W.get(...)
...
$INTERM = $STR.format(..., $DATA, ...)
...
open(..., $INTERM, ...)
- pattern: |
$DATA = request.$W.get(...)
...
$INTERM = $STR.format(..., $DATA, ...)
...
with open(..., $INTERM, ...) as $FD:
...
- pattern: |
$DATA = request.$W.get(...)
...
open(..., $STR % $DATA, ...)
- pattern: |
$DATA = request.$W.get(...)
...
$INTERM = $STR % $DATA
...
open(..., $INTERM, ...)
- pattern: |
$DATA = request.$W.get(...)
...
$INTERM = $STR % $DATA
...
with open(..., $INTERM, ...) as $FD:
...
- pattern: |
$DATA = request.$W.get(...)
...
open(..., f"...{$DATA}...", ...)
- pattern: |
$DATA = request.$W.get(...)
...
$INTERM = f"...{$DATA}..."
...
open(..., $INTERM, ...)
- pattern: |
$DATA = request.$W.get(...)
...
$INTERM = f"...{$DATA}..."
...
with open(..., $INTERM, ...) as $FD:
...
- pattern: |
$DATA = request.$W.get(...)
...
open(..., $STR + $DATA, ...)
- pattern: |
$DATA = request.$W.get(...)
...
$INTERM = $STR + $DATA
...
open(..., $INTERM, ...)
- pattern: |
$DATA = request.$W.get(...)
...
$INTERM = $STR + $DATA
...
with open(..., $INTERM, ...) as $FD:
...
- pattern: $A = open(..., request.$W.get(...), ...)
- pattern: $A = open(..., $S.format(..., request.$W.get(...), ...), ...)
- pattern: $A = open(..., $S % request.$W.get(...), ...)
- pattern: $A = open(..., f"...{request.$W.get(...)}...", ...)
- pattern: return open(..., request.$W.get(...), ...)
- pattern: return open(..., $S.format(..., request.$W.get(...), ...), ...)
- pattern: return open(..., $S % request.$W.get(...), ...)
- pattern: return open(..., f"...{request.$W.get(...)}...", ...)
- pattern: |
$DATA = request.$W.get(...)
...
with open(..., $DATA, ...) as $FD:
...
- pattern: open(..., request.$W(...), ...)
- pattern: open(..., $S.format(..., request.$W(...), ...), ...)
- pattern: open(..., $S % request.$W(...), ...)
- pattern: open(..., f"...{request.$W(...)}...", ...)
- pattern: |
$DATA = request.$W(...)
...
open(..., $DATA, ...)
- pattern: |
$DATA = request.$W(...)
...
$INTERM = $DATA
...
open(..., $INTERM, ...)
- pattern: |
$DATA = request.$W(...)
...
$INTERM = $DATA
...
with open(..., $INTERM, ...) as $FD:
...
- pattern: |
$DATA = request.$W(...)
...
open(..., $STR.format(..., $DATA, ...), ...)
- pattern: |
$DATA = request.$W(...)
...
$INTERM = $STR.format(..., $DATA, ...)
...
open(..., $INTERM, ...)
- pattern: |
$DATA = request.$W(...)
...
$INTERM = $STR.format(..., $DATA, ...)
...
with open(..., $INTERM, ...) as $FD:
...
- pattern: |
$DATA = request.$W(...)
...
open(..., $STR % $DATA, ...)
- pattern: |
$DATA = request.$W(...)
...
$INTERM = $STR % $DATA
...
open(..., $INTERM, ...)
- pattern: |
$DATA = request.$W(...)
...
$INTERM = $STR % $DATA
...
with open(..., $INTERM, ...) as $FD:
...
- pattern: |
$DATA = request.$W(...)
...
open(..., f"...{$DATA}...", ...)
- pattern: |
$DATA = request.$W(...)
...
$INTERM = f"...{$DATA}..."
...
open(..., $INTERM, ...)
- pattern: |
$DATA = request.$W(...)
...
$INTERM = f"...{$DATA}..."
...
with open(..., $INTERM, ...) as $FD:
...
- pattern: |
$DATA = request.$W(...)
...
open(..., $STR + $DATA, ...)
- pattern: |
$DATA = request.$W(...)
...
$INTERM = $STR + $DATA
...
open(..., $INTERM, ...)
- pattern: |
$DATA = request.$W(...)
...
$INTERM = $STR + $DATA
...
with open(..., $INTERM, ...) as $FD:
...
- pattern: $A = open(..., request.$W(...), ...)
- pattern: $A = open(..., $S.format(..., request.$W(...), ...), ...)
- pattern: $A = open(..., $S % request.$W(...), ...)
- pattern: $A = open(..., f"...{request.$W(...)}...", ...)
- pattern: return open(..., request.$W(...), ...)
- pattern: return open(..., $S.format(..., request.$W(...), ...), ...)
- pattern: return open(..., $S % request.$W(...), ...)
- pattern: return open(..., f"...{request.$W(...)}...", ...)
- pattern: |
$DATA = request.$W(...)
...
with open(..., $DATA, ...) as $FD:
...
- pattern: open(..., request.$W[...], ...)
- pattern: open(..., $S.format(..., request.$W[...], ...), ...)
- pattern: open(..., $S % request.$W[...], ...)
- pattern: open(..., f"...{request.$W[...]}...", ...)
- pattern: |
$DATA = request.$W[...]
...
open(..., $DATA, ...)
- pattern: |
$DATA = request.$W[...]
...
$INTERM = $DATA
...
open(..., $INTERM, ...)
- pattern: |
$DATA = request.$W[...]
...
$INTERM = $DATA
...
with open(..., $INTERM, ...) as $FD:
...
- pattern: |
$DATA = request.$W[...]
...
open(..., $STR.format(..., $DATA, ...), ...)
- pattern: |
$DATA = request.$W[...]
...
$INTERM = $STR.format(..., $DATA, ...)
...
open(..., $INTERM, ...)
- pattern: |
$DATA = request.$W[...]
...
$INTERM = $STR.format(..., $DATA, ...)
...
with open(..., $INTERM, ...) as $FD:
...
- pattern: |
$DATA = request.$W[...]
...
open(..., $STR % $DATA, ...)
- pattern: |
$DATA = request.$W[...]
...
$INTERM = $STR % $DATA
...
open(..., $INTERM, ...)
- pattern: |
$DATA = request.$W[...]
...
$INTERM = $STR % $DATA
...
with open(..., $INTERM, ...) as $FD:
...
- pattern: |
$DATA = request.$W[...]
...
open(..., f"...{$DATA}...", ...)
- pattern: |
$DATA = request.$W[...]
...
$INTERM = f"...{$DATA}..."
...
open(..., $INTERM, ...)
- pattern: |