Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typing_extensions in dependencies should be typing-extensions #330

Closed
M1ha-Shvn opened this issue Sep 26, 2024 · 2 comments
Closed

typing_extensions in dependencies should be typing-extensions #330

M1ha-Shvn opened this issue Sep 26, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@M1ha-Shvn
Copy link

M1ha-Shvn commented Sep 26, 2024

Describe the bug
Not a bug, in reality, but lead to confusion in my case.

importlib.metadata.distribution shows typing_extensions requirement as typing_extensions (>=4.7,<5.0) ; python_version < "3.11"'.
The correct name of the library is typing-extensions (I get it as it is written on pypi). This may lead to some confusions in scripts which analyze dependencies as Requirement("typing_extensions") is not equal to Requirement("typing-extensions") (nevertheless, both work and are installed correctly by pip).

To Reproduce

from importlib.metadata import distribution
from packaging.requirements import Requirement

dist = distribution("fakeredis")
for req in dist.requires:
    print(Requirement(req).name)

Expected behavior
library name should be typing-extensions

Desktop (please complete the following information):

  • OS: docker python-3.9-slim
  • python 3.9 (but can be any other)
  • fakeredis[lua]==2.24.1

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • We receive the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
@M1ha-Shvn M1ha-Shvn added the bug Something isn't working label Sep 26, 2024
@cunla
Copy link
Owner

cunla commented Sep 26, 2024

Thanks for reporting this. Do you mind creating a PR for this change? (also run poetry update to update poetry.lock)

@cunla cunla closed this as completed in e5c1c90 Sep 27, 2024
@cunla
Copy link
Owner

cunla commented Sep 27, 2024

Nevermind, I got it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants