Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My review of the new work flow " event opening in viewing mode instead of editing" #80

Open
MaudeFJ opened this issue Aug 5, 2024 · 5 comments
Assignees

Comments

@MaudeFJ
Copy link

MaudeFJ commented Aug 5, 2024

I preferd when it opend in editing mode because I still always need to do some modification so it's one more clic

@troughc
Copy link

troughc commented Aug 6, 2024

Thanks for the review @MaudeFJ, it is true that there is an extra click to enter an event. Duly noted - I will share your feedback.

Note that we made this change to provide Admins with the ability to preview the contents of an event in readonly - it's a quick view to see whether the event data/content meets the needs of the frontend display. You could already do this in the other workspaces (places, people,orgs), but there was no way for Admins to do this in Events. Now Admins are able to see at a glance whether all fields are completed.

A followup enhancement for this feature will be separating language content in the read-only pages (the display breaks out content per language). This future enhancement will be particularly useful for previewing listings that offer event pages in multiple languages.

Hope this provides some context for you.

@MaudeFJ
Copy link
Author

MaudeFJ commented Aug 6, 2024

I personally feel it's easier to see in edit mode, because in read only we only see the fields that are completed and in edit we see the fields that are missing.
Capture d’écran, le 2024-08-06 à 08 15 33
Capture d’écran, le 2024-08-06 à 08 15 39

@troughc
Copy link

troughc commented Sep 20, 2024

@MaudeFJ we changed the read only display so that mandatory fields are always displayed, even if they are missing. For example: https://cms.footlight.io/dashboard/63457978637093005071a053/events/66da98be345131006449a4ee

In this way, you can check the read-only view to make sure all mandatory fields are filled and the event meets your minimum requirements.

@troughc troughc self-assigned this Sep 20, 2024
@MaudeFJ
Copy link
Author

MaudeFJ commented Sep 23, 2024

Hello, That's nice if i can suggest a desing ux thing, if the edit button could follow or be at the end too, because lets say in this case the billeterie is missing so I when all the way down and need to go all the way up again to click on edit and then all the way down to actually edit. so having the bouton closer would make it a bit faster!
Thanks

@troughc
Copy link

troughc commented Sep 23, 2024

Thanks Maude, I will discuss in our Design meetings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants