Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAC Osaka prod calendar - duplicate event bug #1453

Closed
troughc opened this issue Nov 20, 2024 · 8 comments · Fixed by #1454
Closed

NAC Osaka prod calendar - duplicate event bug #1453

troughc opened this issue Nov 20, 2024 · 8 comments · Fixed by #1454
Assignees
Labels
bug Something isn't working NAC Client: National Arts Centre
Milestone

Comments

@troughc
Copy link
Contributor

troughc commented Nov 20, 2024

This seems to only be an issue in the NAC Osaka prod calendar. When I try to duplicate an event, I get an error message.
Steps to reproduce
In list view, click to open the menu next to an event and chose duplicate event.
The event form opens. Click save as draft.
This error appears:
Image

@troughc troughc changed the title NAC Osaka prod calendar bug NAC Osaka prod calendar - duplicate event bug Nov 20, 2024
@troughc troughc added bug Something isn't working NAC Client: National Arts Centre labels Nov 20, 2024
@AbhishekPAnil
Copy link
Contributor

AbhishekPAnil commented Nov 21, 2024

Bug Report:
An error was triggered by the backend when attempting to save an event as a draft.

The payload for creating the event included:
"organizers": [{"type": "Organization"}]
The organizers field was missing an entityId.

This issue occurred because the event being duplicated also had an organizer without an entityId:
Event Link
This event may also have the same issue : https://staging.cms.footlight.io/dashboard/66fa7b17eb00ea006325fc46/events/67377033ad60100064a3d351

To resolve this, I have added an additional check in the frontend to remove any organizer, person, or supporter without an entityId. This ensures that the payload for event creation or updates does not include any organizers, persons, or supporters lacking an entityId.

@sahalali I am assigning this to you,to make the correction in the Backend.

@AbhishekPAnil AbhishekPAnil linked a pull request Nov 21, 2024 that will close this issue
@troughc troughc added this to the CC 2024.1 milestone Nov 22, 2024
@sahalali
Copy link
Contributor

The issue in the backend was that the organization/person importing from Artsdata wasn't getting pulled to CMS, instead the source URI was kept in the CMS. This was causing the issue. Now, the issue is resolved in staging.

@AbhishekPAnil
Copy link
Contributor

AbhishekPAnil commented Nov 27, 2024

@troughc You can test this in the PR link

@sahalali sahalali assigned troughc and unassigned sahalali Nov 27, 2024
@troughc
Copy link
Contributor Author

troughc commented Nov 27, 2024

Tested in PR: PASSED

@troughc
Copy link
Contributor Author

troughc commented Nov 29, 2024

The regression test is failing. Please look into this.

@sahalali
Copy link
Contributor

sahalali commented Dec 2, 2024

@dev-aravind, please allow the code to be deployed until the regression test is stable. Although it looks sleek, there are some issues in the regression test. We need to keep the completed issues and wait until RT is fixed.
Please remove the RT dependency in the workflow for now. Let's add it later once stable.

@kmdvs
Copy link
Collaborator

kmdvs commented Dec 2, 2024

The RT aren't designed for other calendars than Tout Culture... At least, not yet, since I never tested another calendar... It would be great to give my 4 accounts access to all calendars, so I can actually make appropriate changes based on what calendar IS tested. In theory, since the code-base for all calendars is pretty similar (correct me if I am wrong), and the RT use the UI, and the UI don't change that much between calendars, nothing suggests a specific calendar should pose a particular problem other than small exceptions (like clicking on an additional button to edit something, or using an additional drop-down before saving an event).

I would need specific information on what fails to investigate, and more importantly, access to all calendars for my 4 accounts in production :)

@sahalali
Copy link
Contributor

sahalali commented Dec 2, 2024

I am creating a separate ticket to address this issue since the RT failure is not directly dependent on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working NAC Client: National Arts Centre
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants