Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't save Person when modifying even if all mandatory fields filled (including image) #1354

Closed
kmdvs opened this issue Sep 23, 2024 · 7 comments · Fixed by #1377
Closed
Assignees
Labels
bug Something isn't working To be deployed

Comments

@kmdvs
Copy link
Collaborator

kmdvs commented Sep 23, 2024

On Staging, trying to save a Person fails even when an image is given, when modifying

savePerson

Create New functions... And saves... It is the modification that fails...

Repro steps:

  • Create a new Person with mandatory fields
  • Save Person
  • Edit to Modify
  • Without any changes, try to Save again
  • Error message: "This person needs more information before it can be saved."
@kmdvs kmdvs added the bug Something isn't working label Sep 23, 2024
@kmdvs kmdvs changed the title Can't save Person when modifying even if all madatory fields filled (including image) Can't save Person when modifying even if all mandatory fields filled (including image) Sep 23, 2024
@kmdvs
Copy link
Collaborator Author

kmdvs commented Sep 23, 2024

Is the error that image is now mandatory?

I guess it's not just that, since there's an image, but the error message stipulates that the error is about "image". It is as if it complains about a missing image, while there is one.

@kmdvs
Copy link
Collaborator Author

kmdvs commented Sep 23, 2024

This stops Cypress tests from working, in the Modify Person section, when doing @general tests (OK with tags: ['@Important', '@Essential']

Checking Modify existing`, { tags: ['@general']

@troughc troughc assigned AbhishekPAnil and unassigned kmdvs and troughc Sep 25, 2024
@AbhishekPAnil
Copy link
Contributor

cc @AbhishekPAnil This is dependent on #1319

@kmdvs
Copy link
Collaborator Author

kmdvs commented Sep 27, 2024

The same happens in Organizations... A fully filled Org cannot be modified.

@AbhishekPAnil AbhishekPAnil linked a pull request Sep 30, 2024 that will close this issue
@AbhishekPAnil AbhishekPAnil removed a link to a pull request Oct 1, 2024
@AbhishekPAnil AbhishekPAnil linked a pull request Oct 1, 2024 that will close this issue
@troughc
Copy link
Contributor

troughc commented Oct 1, 2024

@kmdvs do you want to test this one? Please assign back to me after. :)

@troughc troughc assigned kmdvs and unassigned troughc Oct 1, 2024
@kmdvs
Copy link
Collaborator Author

kmdvs commented Oct 2, 2024

@troughc Yes, it works for me :)

@kmdvs kmdvs assigned troughc and unassigned kmdvs Oct 2, 2024
@troughc
Copy link
Contributor

troughc commented Oct 2, 2024

@kmdvs thank you. :) I am testing too.

Tested: PASSED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working To be deployed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants