Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max width minimum value for images #1229

Closed
troughc opened this issue Jul 15, 2024 · 3 comments · Fixed by #1323
Closed

Max width minimum value for images #1229

troughc opened this issue Jul 15, 2024 · 3 comments · Fixed by #1323
Assignees
Labels
bug Something isn't working enhancement New feature or request To be deployed

Comments

@troughc
Copy link
Contributor

troughc commented Jul 15, 2024

This issue was found whilst testing #1202
In Artbi, the max width can be set to 0 and the ADMIN can save this setting. This should be disallowed in the software.

SUGGESTED MINIMUM WIDTH ALLOWED: 100 Pixels

Expected Behaviour

Add validation to back-end to expect a minimum of 100 pixels for maximum width.

And when the minimum amount is not entered, or the Max Width field is left empty:
English
CHANGE
Information is required
TO
A minimum value of 100 pixels is required.

French
CHANGE
Des informations sont requises
TO
Une valeur minimale de 100 pixels est requise.

Image

@troughc troughc self-assigned this Jul 15, 2024
@troughc
Copy link
Contributor Author

troughc commented Jul 16, 2024

@troughc add validation method and minimum number allowed for max width.

@troughc troughc added the question Further information is requested label Jul 30, 2024
@troughc troughc changed the title Max width minimum value Max width minimum value for images Sep 3, 2024
@troughc troughc added bug Something isn't working enhancement New feature or request and removed question Further information is requested labels Sep 11, 2024
@AbhishekPAnil AbhishekPAnil linked a pull request Sep 12, 2024 that will close this issue
@sahalali
Copy link
Contributor

@AbhishekPAnil Backend changes have been released. Please review this and move the ticket to the review phase.

@troughc
Copy link
Contributor Author

troughc commented Sep 13, 2024

Tested: PASSED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request To be deployed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants