-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility: Element ID is not unique #428
Comments
This also appears on the 3.1.0 crawl: id="content" is used twice. |
This should now be fixed per #456, I re-crawled one page in SiteImprove and the error went away. Will close this once SI does a full crawl and I can confirm that the issue is gone. |
The repeating id="content" code has been cleaned out of the template, but this issue is still being flagged for multiple viewers on a page. I'm not sure how we get around this built-in functionality. |
The issue that is still here with this is in relation to the zoomable images that can be embedded on a page. OpenSeadragon requires an ID be passed to it for the functionality to work. Since these are dynamically generated, all of them have the same ID from the template. To make this work, we would need either unique IDs for all of these buttons when they're generated or to remove the ability to zoom on these embeds. |
The toolbar controls buttons were being created in the Blacklight Gallery gem. I copied the template over and removed the control pieces to be able to fix this issue. The only problem now is that the images can still zoom on scroll/click. Would we want to disable this or leave it as is? |
@kevinkidwell Does it seem awkward that you can zoom with scroll/click? Seems like it might be, like surprise functionality that should be more obvious if it's there. |
This is fixed on prod now (was related to osd viewer). |
Description
Any element on a page must have a unique ID. This issue appears when items on a page both have the same ID, typically from embeds or other generated templates that can be repeated.
This particular issue is present on the Item Embed on the controls for an item: zoom in, zoom out, home, and fullscreen.
Solution
Option 1: Do not allow multiple item embeds on a single page.
Option 2: Remove the IDs and adjust any relevant code that referred to these IDs
The text was updated successfully, but these errors were encountered: