Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.7.7 breakes the build on Windows #487

Open
henrify opened this issue Apr 20, 2016 · 2 comments
Open

3.7.7 breakes the build on Windows #487

henrify opened this issue Apr 20, 2016 · 2 comments

Comments

@henrify
Copy link

henrify commented Apr 20, 2016

Cloning the repo and trying to build fails at the 'browserify' script on Windows 8.1 with Node 4.4.3 64bit.

3.7.3 builds fine in windows.

Below is output from running just the browserify script.


PS F:\Projects_Modified\JavaScript\when-fix> npm run browserify

[email protected] browserify F:\Projects_Modified\JavaScript\when-fix
npm run browserify-es6 && npm run browserify-when && npm run browserify-debug

[email protected] browserify-es6 F:\Projects_Modified\JavaScript\when-fix
browserify -s Promise es6-shim/Promise.browserify-es6.js --no-detect-globals --debug | exorcist -b . -r https://raw.githubusercontent.com/cujojs/when/`git rev-parse HEAD` es6-shim/Promise.js.map >es6-shim/Promise.js

[email protected] browserify-when F:\Projects_Modified\JavaScript\when-fix
mkdir -p dist/browser && browserify -s when build/when.browserify.js --no-detect-globals --debug | exorcist -b . -r https://raw.githubusercontent.com/cujojs/when/`git rev-parse HEAD` dist/browser/when.js.map >dist/browser/when.js

The syntax of the command is incorrect.

npm ERR! Windows_NT 6.3.9600
npm ERR! argv "C:\Program Files\nodejs\node.exe" "C:\Program Files\nodejs\node_modules\npm\bin\npm-cli.js" "run" "browserify-when"
npm ERR! node v4.4.3
npm ERR! npm v2.15.1
npm ERR! code ELIFECYCLE
npm ERR! [email protected] browserify-when: mkdir -p dist/browser && browserify -s when build/when.browserify.js --no-detect-globals --debug | exorcist -b . -r https://raw.githubusercontent.com/cujojs/when/git rev-parse HEADdist/browser/when.js.map >d ist/browser/when.js
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] browserify-when script 'mkdir -p dist/browser && browserify -s when build/when.browserify.js --no-detect-globals --debug | exorcist -b . -r https://raw.githubusercontent.com/cujojs/when/`git rev-parse HEADdist/br owser/when.js.map >dist/browser/when.js'. npm ERR! This is most likely a problem with the when package, npm ERR! not with npm itself. npm ERR! Tell the author that this fails on your system: npm ERR! mkdir -p dist/browser && browserify -s when build/when.browserify.js --no-detect-globals --debug | exorcist -b . -r https://raw.githubusercontent.com/cujojs/when/git rev-parse HEAD` dist/browser/when.js.map >dist/browser/when.js
npm ERR! You can get information on how to open an issue for this project with:
npm ERR! npm bugs when
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!
npm ERR! npm owner ls when
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR! F:\Projects_Modified\JavaScript\when-fix\npm-debug.log

npm ERR! Windows_NT 6.3.9600
npm ERR! argv "C:\Program Files\nodejs\node.exe" "C:\Program Files\nodejs\node_modules\npm\bin\npm-cli.js" "run" "browserify"
npm ERR! node v4.4.3
npm ERR! npm v2.15.1
npm ERR! code ELIFECYCLE
npm ERR! [email protected] browserify: npm run browserify-es6 && npm run browserify-when && npm run browserify-debug
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] browserify script 'npm run browserify-es6 && npm run browserify-when && npm run browserify-debug'.
npm ERR! This is most likely a problem with the when package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR! npm run browserify-es6 && npm run browserify-when && npm run browserify-debug
npm ERR! You can get information on how to open an issue for this project with:
npm ERR! npm bugs when
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!
npm ERR! npm owner ls when
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR! F:\Projects_Modified\JavaScript\when-fix\npm-debug.log

@henrify
Copy link
Author

henrify commented Apr 20, 2016

Checking more. Are you trying to use unix backticks? as in git rev-parse HEAD?

@briancavalier
Copy link
Member

We can switch this to use $() like you suggested. I should have time to do that tonight or tomorrow.

@henrify henrify changed the title 3.7.7 brakes the build on Windows 3.7.7 breakes the build on Windows May 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants