New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIelds are of wrong type in the OrganizationEvent webhook #37

Closed

TomMD opened this issue Oct 12, 2020 · 1 comment · Fixed by #38

Assignees

Labels

bug

Contributor

TomMD commented Oct 12, 2020

In both practice and documentation the Org Event type needs the invitation and membership fields to be optional. Read https://developer.github.com/webhooks/event-payloads/#organization

Currently these are not Maybe types so the parse of many org events fails (ex: delete a user from an org).

TomMD mentioned this issue

Make optional fields optional and fix the JSON parse #38

Merged

7 tasks

Member

kvanbere commented Oct 14, 2020

Fixed by #38

kvanbere closed this as completed

kvanbere added the bug label

kvanbere assigned TomMD

kvanbere linked a pull request

that will close this issue

Make optional fields optional and fix the JSON parse #38

Merged

7 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment