Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanish translation for Feature and Rule synonym keywords #1360

Merged
merged 14 commits into from
Mar 9, 2021
Merged

Spanish translation for Feature and Rule synonym keywords #1360

merged 14 commits into from
Mar 9, 2021

Conversation

sergioforerogomez
Copy link
Contributor

@sergioforerogomez sergioforerogomez commented Feb 12, 2021

Summary

Translated keywords

Motivation and Context

Translations missing

How Has This Been Tested?

It hasn't

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • The change has been ported to Java.
  • The change has been ported to Ruby.
  • The change has been ported to JavaScript.
  • The change has been ported to Go.
  • The change has been ported to .NET.
  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have updated the CHANGELOG accordingly.

@aslakhellesoy
Copy link
Contributor

Muchas gracias!

I'm not sure it is a good idea to have two synonyms where one is a substring of the other. Do we really need both Necesidad del negocio and Necesidad? And both Regla de negocio and Regla?

@sergioforerogomez
Copy link
Contributor Author

Muchas gracias!

I'm not sure it is a good idea to have two synonyms where one is a substring of the other. Do we really need both Necesidad del negocio and Necesidad? And both Regla de negocio and Regla?

Hi!

In Spanish it isn't as descriptive as we would like to have just Regla, so we can start working with Cucumber 6 rules.
And, we can't just replace it, that's why.

What would you think if I take just one for Necesidad del negocio and Necesidad, and we keep both for Rules?

@aslakhellesoy aslakhellesoy added ⚡ enhancement Request for new functionality library: gherkin labels Feb 14, 2021
@sergioforerogomez
Copy link
Contributor Author

@aslakhellesoy I've made the change and all checks have passed! :D

@aurelien-reeves aurelien-reeves merged commit 5c83972 into cucumber:master Mar 9, 2021
@aslakhellesoy
Copy link
Contributor

Hi @sergioforerogomez,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
library: gherkin ⚡ enhancement Request for new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants