Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--publish: use banner provided by server #1472

Closed
vincent-psarga opened this issue Sep 7, 2020 · 0 comments · Fixed by #1483
Closed

--publish: use banner provided by server #1472

vincent-psarga opened this issue Sep 7, 2020 · 0 comments · Fixed by #1483

Comments

@vincent-psarga
Copy link
Contributor

The messages.cucumber.io server responds with the banner as part of the 202 pesudo-redirect response. We should use it instead of computing our own like we do in cucumber-js#1424.

Advantages:

  • people can override CUCUMBER_PUBLISH_URL and no longer get a banner pointing to reports.cucumber.io
  • server implementation can provide their own banner
  • no need to release new cucumber-ruby when changing the wording/styling of the banner or location of the report web app
  • more consistency between cucumber implementations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant