Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Log warning when classes could not be loaded #2235

Merged
merged 1 commit into from
Feb 12, 2021

Conversation

mpkorstanje
Copy link
Contributor

@mpkorstanje mpkorstanje commented Feb 11, 2021

Fixes: #2212, #2229.

@mpkorstanje mpkorstanje force-pushed the log-warnings-when-class-loading-fails branch from d818f0d to f83c53d Compare February 11, 2021 17:46
@mpkorstanje mpkorstanje added this to the v6.x.x milestone Feb 11, 2021
@codecov
Copy link

codecov bot commented Feb 11, 2021

Codecov Report

Merging #2235 (056d2d7) into main (c273364) will decrease coverage by 0.01%.
The diff coverage is 77.77%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2235      +/-   ##
============================================
- Coverage     82.81%   82.79%   -0.02%     
- Complexity     2332     2340       +8     
============================================
  Files           306      306              
  Lines          8308     8319      +11     
  Branches        764      764              
============================================
+ Hits           6880     6888       +8     
- Misses         1116     1120       +4     
+ Partials        312      311       -1     
Impacted Files Coverage Δ Complexity Δ
...ucumber/core/resource/JarUriFileSystemService.java 90.24% <ø> (+2.43%) 24.00 <0.00> (+1.00)
.../src/main/java/io/cucumber/java/MethodScanner.java 81.25% <42.85%> (-6.85%) 34.00 <2.00> (+2.00) ⬇️
...va/io/cucumber/core/resource/ClasspathScanner.java 95.00% <100.00%> (+0.12%) 25.00 <2.00> (+2.00)
...va/io/cucumber/core/resource/ClasspathSupport.java 78.78% <100.00%> (+0.32%) 25.00 <1.00> (+1.00)
...in/java/io/cucumber/core/resource/PathScanner.java 77.14% <100.00%> (+2.14%) 8.00 <2.00> (+2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c273364...056d2d7. Read the comment docs.

@mpkorstanje mpkorstanje force-pushed the log-warnings-when-class-loading-fails branch 5 times, most recently from 1038dbb to b6ebbaf Compare February 12, 2021 20:26
@mpkorstanje mpkorstanje force-pushed the log-warnings-when-class-loading-fails branch from b6ebbaf to 056d2d7 Compare February 12, 2021 21:00
@mpkorstanje mpkorstanje marked this pull request as ready for review February 12, 2021 21:03
@mpkorstanje mpkorstanje merged commit e0ad566 into main Feb 12, 2021
@mpkorstanje mpkorstanje deleted the log-warnings-when-class-loading-fails branch February 12, 2021 21:08
This was referenced Mar 9, 2021
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClasspathScanner fails if classloader contains custom URI scemes
1 participant