-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--publish: use banner provided by server #2116
Comments
At this point it might be good to duplicate the URL output stream and only use it for the publish plugin. |
Are you suggesting we remove the ability to specify a URL for arbitrary plugins, or are you suggesting we have 2 implementations of |
For now duplicate it. In the long run, deprecate and remove it for arbitrary plugins. I don't see much value in abitrary uploads. With Gitlab the file is uploaded to pages. Don't know how other CIs do it but I would expect a similar flow. Or if the file server is remote I would expect people to upload the report with curl. I wouldn't expect anyone to implement a server and use the exact protocol we are creating right now. |
What do you mean? |
Gitlab pages. |
Actual looks like this can be done without changing much of the protocol. |
The messages.cucumber.io server responds with the banner as part of the 202 pesudo-redirect response. We should use it instead of computing our own like we do in cucumber-js#1424.
Advantages:
The text was updated successfully, but these errors were encountered: