Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--publish: use banner provided by server #2116

Closed
vincent-psarga opened this issue Sep 7, 2020 · 6 comments
Closed

--publish: use banner provided by server #2116

vincent-psarga opened this issue Sep 7, 2020 · 6 comments

Comments

@vincent-psarga
Copy link
Contributor

The messages.cucumber.io server responds with the banner as part of the 202 pesudo-redirect response. We should use it instead of computing our own like we do in cucumber-js#1424.

Advantages:

  • people can override CUCUMBER_PUBLISH_URL and no longer get a banner pointing to reports.cucumber.io
  • server implementation can provide their own banner
  • no need to release new cucumber-ruby when changing the wording/styling of the banner or location of the report web app
  • more consistency between cucumber implementations
@mpkorstanje
Copy link
Contributor

At this point it might be good to duplicate the URL output stream and only use it for the publish plugin.

@aslakhellesoy
Copy link
Contributor

Are you suggesting we remove the ability to specify a URL for arbitrary plugins, or are you suggesting we have 2 implementations of URLOutputStream?

@mpkorstanje
Copy link
Contributor

For now duplicate it. In the long run, deprecate and remove it for arbitrary plugins. I don't see much value in abitrary uploads.

With Gitlab the file is uploaded to pages. Don't know how other CIs do it but I would expect a similar flow.

Or if the file server is remote I would expect people to upload the report with curl. I wouldn't expect anyone to implement a server and use the exact protocol we are creating right now.

@aslakhellesoy
Copy link
Contributor

With Gitlab the file is uploaded to pages

What do you mean?

@mpkorstanje
Copy link
Contributor

@mpkorstanje
Copy link
Contributor

Actual looks like this can be done without changing much of the protocol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants