Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User test findings #1780

Closed
4 tasks done
mpkorstanje opened this issue Sep 26, 2019 · 6 comments
Closed
4 tasks done

User test findings #1780

mpkorstanje opened this issue Sep 26, 2019 · 6 comments
Milestone

Comments

@mpkorstanje
Copy link
Contributor

mpkorstanje commented Sep 26, 2019

@mpkorstanje mpkorstanje added this to the 5.0.0 milestone Sep 26, 2019
@aslakhellesoy
Copy link
Contributor

All of this can be reproduced by upgrading https://github.com/cucumber-ltd/shouty.java

Other issues:

  • Don't suggest snippets with And and But (use the previous GWT keyword)
  • Don't generate annotations (java) and functions (java8) for And and But

@mpkorstanje
Copy link
Contributor Author

mpkorstanje commented Sep 28, 2019

Don't generate annotations (java) and functions (java8) for And and But

This has been Cucumber since at least 2.0.0. We'll have to pull it through a deprecation process.

https://github.com/cucumber/cucumber-jvm/blob/v2.0.0/java/pom.xml#L94

@mpkorstanje
Copy link
Contributor Author

Don't suggest snippets with And and But (use the previous GWT keyword)

Resolved by: #1783

@mpkorstanje
Copy link
Contributor Author

The cucumber-glue scope does not appear to work as it used to in 3.0.0.

@aslakhellesoy or @sebrose can you describe this issue a bit better? There is a unit test to confirm that beans annotated with @Scope(CucumberTestContext.SCOPE_CUCUMBER_GLUE) are not reused between scenarios.

https://github.com/cucumber/cucumber-jvm/blob/master/spring/src/test/java/io/cucumber/spring/SpringFactoryTest.java#L274

@mpkorstanje
Copy link
Contributor Author

@aslakhellesoy I suggested to remove strict altogether in cucumber/common#714 wdyt? It will be easier to remove strict then it will be to flip it around.

@mpkorstanje
Copy link
Contributor Author

Don't generate annotations (java) and functions (java8) for And and But

Will be resolved by #1787

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants