From 6ef2755dbe0fb41a0d100cf1c2ced12bcfad4efd Mon Sep 17 00:00:00 2001 From: Matt Travi Date: Wed, 20 Apr 2022 14:23:59 -0500 Subject: [PATCH 1/5] fix(message-streams): defined direct dependency to satisfy gherkin-streams peer requirement for consumers closes #2005 --- package-lock.json | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/package-lock.json b/package-lock.json index acbcfdd00..692051fab 100644 --- a/package-lock.json +++ b/package-lock.json @@ -16,6 +16,7 @@ "@cucumber/gherkin-streams": "5.0.1", "@cucumber/gherkin-utils": "^7.0.0", "@cucumber/html-formatter": "19.1.0", + "@cucumber/message-streams": "^4.0.1", "@cucumber/messages": "18.0.0", "@cucumber/tag-expressions": "4.1.0", "assertion-error-formatter": "^3.0.0", @@ -49,7 +50,6 @@ }, "devDependencies": { "@cucumber/compatibility-kit": "9.2.0", - "@cucumber/message-streams": "4.0.1", "@cucumber/query": "11.0.0", "@microsoft/api-documenter": "7.17.0", "@microsoft/api-extractor": "7.20.0", diff --git a/package.json b/package.json index 2cb9f9bbd..edcb8ec20 100644 --- a/package.json +++ b/package.json @@ -201,6 +201,7 @@ "@cucumber/gherkin-streams": "5.0.1", "@cucumber/gherkin-utils": "^7.0.0", "@cucumber/html-formatter": "19.1.0", + "@cucumber/message-streams": "^4.0.1", "@cucumber/messages": "18.0.0", "@cucumber/tag-expressions": "4.1.0", "assertion-error-formatter": "^3.0.0", @@ -231,7 +232,6 @@ }, "devDependencies": { "@cucumber/compatibility-kit": "9.2.0", - "@cucumber/message-streams": "4.0.1", "@cucumber/query": "11.0.0", "@microsoft/api-documenter": "7.17.0", "@microsoft/api-extractor": "7.20.0", From 40ff1902fa32c3b02fb9984d60b2e92337d5907b Mon Sep 17 00:00:00 2001 From: Matt Travi Date: Wed, 20 Apr 2022 14:29:06 -0500 Subject: [PATCH 2/5] docs(changelog): mentioned satisfying of peer requirement by depending on massage-streams --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index d98ee1f4d..b07529abb 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,8 @@ Please see [CONTRIBUTING.md](https://github.com/cucumber/cucumber/blob/master/CO ## [Unreleased] +- Capture dependency on `@cucumber/message-streams` to satisfy peer requirement from `@cucumber/gherkin-streams` ([#2006](https://github.com/cucumber/cucumber-js/pull/2006)) + ## [8.1.0] - 2022-04-20 ### Added - Add support for named hooks (see [documentation](./docs/support_files/hooks.md#named-hooks)) ([#1994](https://github.com/cucumber/cucumber-js/pull/1994)) From f69ceb616507d3b22687c767f80d7cb1d69f42db Mon Sep 17 00:00:00 2001 From: David Goss Date: Wed, 20 Apr 2022 21:11:31 +0100 Subject: [PATCH 3/5] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b07529abb..8ac402955 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,7 +8,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/). Please see [CONTRIBUTING.md](https://github.com/cucumber/cucumber/blob/master/CONTRIBUTING.md) on how to contribute to Cucumber. ## [Unreleased] - +### Fixed - Capture dependency on `@cucumber/message-streams` to satisfy peer requirement from `@cucumber/gherkin-streams` ([#2006](https://github.com/cucumber/cucumber-js/pull/2006)) ## [8.1.0] - 2022-04-20 From 4bd3ea211de94cafe1801c7626f6b01b23e65321 Mon Sep 17 00:00:00 2001 From: David Goss Date: Wed, 20 Apr 2022 21:13:25 +0100 Subject: [PATCH 4/5] Update dependency-lint.yml --- dependency-lint.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/dependency-lint.yml b/dependency-lint.yml index 17fbca150..7edf11b76 100644 --- a/dependency-lint.yml +++ b/dependency-lint.yml @@ -18,6 +18,7 @@ ignoreErrors: shouldBeDependency: [] shouldBeDevDependency: [] unused: + - '@cucumber/message-streams' # peer dependency of @cucumber/gherkin-streams - '@cucumber/compatibility-kit' # files dynamically loaded in cck test, not require'd - '@typescript-eslint/eslint-plugin' # peer dependency of standard-with-typescript - '@typescript-eslint/parser' # peer dependency of @typescript-eslint/eslint-plugin From 86d19ddbf1d7bc63c1250d0b27cb0ffc2b9e319d Mon Sep 17 00:00:00 2001 From: David Goss Date: Wed, 20 Apr 2022 21:17:20 +0100 Subject: [PATCH 5/5] Update dependency-lint.yml --- dependency-lint.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dependency-lint.yml b/dependency-lint.yml index 7edf11b76..8bba52fca 100644 --- a/dependency-lint.yml +++ b/dependency-lint.yml @@ -16,9 +16,9 @@ executedModules: ignoreErrors: missing: [] shouldBeDependency: [] - shouldBeDevDependency: [] - unused: + shouldBeDevDependency: - '@cucumber/message-streams' # peer dependency of @cucumber/gherkin-streams + unused: - '@cucumber/compatibility-kit' # files dynamically loaded in cck test, not require'd - '@typescript-eslint/eslint-plugin' # peer dependency of standard-with-typescript - '@typescript-eslint/parser' # peer dependency of @typescript-eslint/eslint-plugin