-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support repeatable tags option #940
Conversation
Thanks for the pull request. Couple things I would like this PR to have:
|
Added docs and test |
@@ -45,6 +45,13 @@ Feature: Target specific scenarios | |||
Then it fails | |||
And it runs the scenario "first scenario" | |||
|
|||
Scenario: merge multiple tag expressions | |||
When I run cucumber.js with `--tags @b --tags @d` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this test would pass without your source code change (which is why its important to write your tests first) because second scenario - Z
is the only scenario with @d
. Thus without the repeatable option, I expect this to pass. Maybe switch to @a
and @d
?
Hi @kozhevnikov, Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾 In return for this generous offer we hope you will:
On behalf of the Cucumber core team, |
Released in 3.0.4 |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Implement #939