Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support repeatable tags option #940

Merged
merged 4 commits into from
Oct 4, 2017
Merged

Support repeatable tags option #940

merged 4 commits into from
Oct 4, 2017

Conversation

kozhevnikov
Copy link
Member

@kozhevnikov kozhevnikov commented Sep 28, 2017

Implement #939

@charlierudolph
Copy link
Member

Thanks for the pull request. Couple things I would like this PR to have:

  • a test (probably in features/target_specific_scenarios_by_tag.feature)
  • documentation update (indocs/cli.md, mentioning that it is repeatable and joined with an and)

@kozhevnikov
Copy link
Member Author

Added docs and test

@@ -45,6 +45,13 @@ Feature: Target specific scenarios
Then it fails
And it runs the scenario "first scenario"

Scenario: merge multiple tag expressions
When I run cucumber.js with `--tags @b --tags @d`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this test would pass without your source code change (which is why its important to write your tests first) because second scenario - Z is the only scenario with @d. Thus without the repeatable option, I expect this to pass. Maybe switch to @a and @d?

@charlierudolph charlierudolph merged commit fb9e8fc into cucumber:master Oct 4, 2017
@aslakhellesoy
Copy link
Contributor

Hi @kozhevnikov,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

@charlierudolph
Copy link
Member

Released in 3.0.4

@lock
Copy link

lock bot commented Oct 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants