Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed tests to run on Windows #216

Closed
wants to merge 1 commit into from
Closed

Fixed tests to run on Windows #216

wants to merge 1 commit into from

Conversation

kostya-misura
Copy link
Contributor

No description provided.

@samccone
Copy link
Member

samccone commented Aug 4, 2014

👍

@samccone
Copy link
Member

samccone commented Aug 4, 2014

I also thing we will want to add a unit test to this to ensure the fix works and we do not regress.

@samccone samccone added the bug label Aug 4, 2014
@kostya-misura
Copy link
Contributor Author

it might be wide to use something like https://www.npmjs.org/package/normalize-newline To reduce to complexity of this line.

Do you think we really need an additional dependency just for call to "str.replace(/\r\n/g, '\n');"?

I also thing we will want to add a unit test to this to ensure the fix works and we do not regress.

I'm gladly do this, but I want to note that this fix does not related to functionality. This is fix for tests themselves. Of couse method "_normalizeString" can be considered as "helper" that can be moved somewhere and then tested, but in this case I would appreciate if you can suggest how to organize things out. (Where to move it, where to place the tests, and so forth). I haven't found anything like that in the project, probably I've missed it.

@jbpros jbpros closed this in cc772fc Dec 21, 2014
@jbpros
Copy link
Member

jbpros commented Dec 21, 2014

Thanks @kostya-misura!

@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants