Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove generators #1021

Closed
charlierudolph opened this issue Jan 24, 2018 · 3 comments · Fixed by #1725
Closed

remove generators #1021

charlierudolph opened this issue Jan 24, 2018 · 3 comments · Fixed by #1725
Labels
💔 breaking change This will require a major release
Milestone
8.0.0

Comments

@charlierudolph
Copy link
Member

Remove generator snippet interface in favor of async-await and remove setDefinitionFunctionWrapper since that was used to turn generator functions into promises. Appears setDefinitionFunctionWrapper has been used for other things so need to ensure #997 can address the use case of being able to wrap a step with custom logic.
@davidjgoss davidjgoss added this to the 8.0.0 milestone Jan 27, 2021
@davidjgoss davidjgoss added the 💔 breaking change This will require a major release label Jan 27, 2021
@davidjgoss
Copy link
Contributor

@charlierudolph looping back to this now BeforeStep and AfterStep are a thing. Maybe a PR now to mark setDefinitionFunctionWrapper as deprecated, and then we remove for v8.0.0 when the time comes?

@charlierudolph
Copy link
Member Author

Sounds good to me

@davidjgoss
Copy link
Contributor

Note to self that we should be able to finish removing bluebird as part of this, see #1566

@charlierudolph charlierudolph mentioned this issue Jul 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💔 breaking change This will require a major release
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

remove support for generators cucumber/cucumber-js
2 participants
@charlierudolph @davidjgoss