@announce tag too verbose in 0.4.6

[robertwahler]

The new call to stop_processes! in all_stdout and all_stderr is causing output to the console to be called on every step with the @announce tag.

If I run aruba's own feature in 0.4.6:

 bundle exec cucumber features/output.feature:75

I get, among the correct output, 5 lines of:

 ruby 1.8.7 (2010-12-23 patchlevel 330) [x86_64-linux]

I should see that line only once, or at least that was the 'nicer' behavior in 0.4.5.

Thanks!

-robert

[mattwynne]

Is there any chance you could investigate this for us? Ideally you would trap it with a spec around Aruba::Api, could you help with that please?

[robertwahler]

Matt, are you suggesting that we create an RSpec test suite so that we can unit test the API?

[mattwynne]

On 3 Nov 2011, at 13:15, Robert Wahler wrote:

Matt, are you suggesting that we create an RSpec test suite so that we can unit test the API?

yes, exactly. The features are more like usage examples, which is fine as far as it goes but no good for fixing bugs like this.

Would you mind?

[robertwahler]

I'll do a quick first cut. I've started a new branch 'add_rspec' here:
https://github.com/robertwahler/aruba/tree/add_rspec

[robertwahler]

What do folks think of this methodology / style for the specs?

https://github.com/robertwahler/aruba/tree/add_rspec

[mattwynne]

Great! I think I'd have been tempted just to include Aruba::API directly into the examples, but the way you're doing makes sense too.

Did you fix the bug yet?

[robertwahler]

I fixed the bug by reverting one of your commits but this causes 4 existing features to fail.

https://github.com/robertwahler/aruba/tree/fix_announce_tag

Failing Scenarios:
cucumber features/flushing.feature:19 # Scenario: Tons of interactive output
cucumber features/output.feature:175 # Scenario: Detect output from all processes
cucumber features/output.feature:187 # Scenario: Detect stdout from all processes
cucumber features/output.feature:203 # Scenario: Detect stderr from all processes

However, the new specs pass :)

I think we need to spec out the stop_process functionality but I don't have time right now.