Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve configuration for disk usage calculation #538

Open
mvz opened this issue Feb 5, 2018 · 1 comment
Open

Improve configuration for disk usage calculation #538

mvz opened this issue Feb 5, 2018 · 1 comment

Comments

@mvz
Copy link
Contributor

mvz commented Feb 5, 2018

We should use actual bytes to configure the allocation unit, and allow autodetection.

Summary

As explained in the comments for #minimum_disk_space_used, the configuration of the disk space calculator uses 8-byte units. This is very confusing. We should also follow-up on the other TODOs in that comment.

Expected Behavior

Allocation unit configuration can be set to actual block size in bytes, or nil for autodetection.

Current Behavior

Size needs to be set in units of 8 bytes.

Context & Motivation

This will make the disk usage feature easier to use, especially if autodetection can be achieved.

@mvz mvz changed the title Fix configuration for disk usage calculation Improve configuration for disk usage calculation Feb 5, 2018
@stale
Copy link

stale bot commented Apr 6, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

@stale stale bot added the stale These issues were closed by stalebot and need to be reviewed to see if they're still relevant. label Apr 6, 2018
@mvz mvz added the slow burner label Apr 6, 2018
@stale stale bot removed the stale These issues were closed by stalebot and need to be reviewed to see if they're still relevant. label Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant