Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename 'cli' used in tests to avoid local test failures #360

Closed
e2 opened this issue Mar 31, 2016 · 0 comments · Fixed by #390
Closed

Rename 'cli' used in tests to avoid local test failures #360

e2 opened this issue Mar 31, 2016 · 0 comments · Fixed by #390

Comments

@e2
Copy link
Contributor

e2 commented Mar 31, 2016

Summary

Aruba's Cucumber scenarios uses "cli" as a cli program for testing. On my system, this resolves to the cli utility from the Debian mono-runtime package. This causes tests to fail locally.

Expected Behavior

Aruba's tests should be green, even when run locally.

Current Behavior

Aruba's tests will fail on systems with mono-runtime installed.

Possible Solution

Explained here: #350 (comment)

Basically, it's about replacing: bin/cli invocations with: bin/aruba-test-cmd.

I'll probably get to it - after my other PRs are merged (to avoid merge conflicts since there could be quite a bit of changes here).

The other solution is to use Docker for testing locally (#353).

Steps to Reproduce (for bugs)

  1. On Ubuntu install mono-runtime
  2. Run Cucumber tests on Aruba's master branch
  3. Tests expecting /bin/cli to not exist will strangely fail.

Context

Failing local tests discourage from contributing.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants