Remove _file/_directory in method names #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase please? |
added 6 commits
May 7, 2015 10:06
|
Ok. |
…d is not needed anymore.
|
@mattwynne |
mattwynne
added a commit
that referenced
this pull request
May 7, 2015
Remove _file/_directory in method names
|
Thanks a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we have
file?anddirectory?in place, I see no need to haveremove_file,remove_directoryandtouch_fileanymore.Be stating
_fileand_directoryin the name we mix a test and an action. I think users should use thefile?anddirectory?-methods for tests andremoveandtouchfor actions.I changed the implementation of the given methods to work both on files and directories. All relevant changes are from the 2nd of May.
This PR is based on #237.