From 6c55ba973db20f477cb4fb42742c2a86553765cd Mon Sep 17 00:00:00 2001 From: Tobias Grieger Date: Fri, 6 May 2022 11:38:10 +0200 Subject: [PATCH] testutils: remove stack trace from SucceedsWithin It has `t.Helper()` so it will already show the caller. Release note: None --- pkg/testutils/soon.go | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/pkg/testutils/soon.go b/pkg/testutils/soon.go index 42419606d2d6..33eb35f1547c 100644 --- a/pkg/testutils/soon.go +++ b/pkg/testutils/soon.go @@ -12,7 +12,6 @@ package testutils import ( "context" - "runtime/debug" "time" "github.com/cockroachdb/cockroach/pkg/util" @@ -56,8 +55,7 @@ func SucceedsSoonError(fn func() error) error { func SucceedsWithin(t TB, fn func() error, duration time.Duration) { t.Helper() if err := SucceedsWithinError(fn, duration); err != nil { - t.Fatalf("condition failed to evaluate within %s: %s\n%s", - duration, err, string(debug.Stack())) + t.Fatalf("condition failed to evaluate within %s: %s", duration, err) } }