Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

__trunk_address__ in WSS url is not getting replaced #9

Closed
lpotthast opened this issue Nov 21, 2023 · 2 comments
Closed

__trunk_address__ in WSS url is not getting replaced #9

lpotthast opened this issue Nov 21, 2023 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@lpotthast
Copy link

I'm now seeing these browser-console-errors using the latest released trunk-ng build.

WebSocket connection to 'wss://{{__trunk_address__}}/_trunk/ws' failed:

Seems that the html_address_middleware is not working as it should..

@lpotthast lpotthast changed the title acme-accounts:118 WebSocket connection to 'wss://{{__trunk_address__}}/_trunk/ws' failed: __trunk_address__ in WSS url is not getting replaced Nov 21, 2023
@ctron ctron added bug Something isn't working help wanted Extra attention is needed labels Nov 24, 2023
@ctron
Copy link
Owner

ctron commented Nov 24, 2023

That's interesting because (aside from "works for me") the replacement string is lowercase, while it actually is uppercase.

@ctron
Copy link
Owner

ctron commented Nov 24, 2023

So, the only case where this would seem to fail is when the Host header is not sent in the request from the browser (or something intercepts this in the middle).

@ctron ctron closed this as completed in 0fa8897 Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants