Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Italic styles have corrupt OS/2 metrics! #19

Open
northgardner opened this issue Feb 18, 2022 · 6 comments
Open

Italic styles have corrupt OS/2 metrics! #19

northgardner opened this issue Feb 18, 2022 · 6 comments
Labels
B-major This is an extremely serious bug likely to affect many or most users. bug Something isn't working

Comments

@northgardner
Copy link

Please remove if this is not the appropriate channel for this report. I have been using TT2020 in various text editors that will render italics for Markdown (among other uses). On a few that I have tried, when using TT2020Base or TT2020 Style E, using italics will cause either the italic word or the whole line to move lower relative to the line above it. The editors this happens with include Atom, Sublime Text, VS Codium, and Mark Text. I'll attach one screenshot from Sublime Text and one from Atom that show both behaviors.
sublime_TT2020E
Atom_TT2020Base

@ctrlcctrlv
Copy link
Owner

I believe that the metrics are clashing in a way I did not intend. I probably failed to make some element of the metrics equivalent, even though in the browser and most WYSIWYG editors they are equivalent.

After I switch to a fontmake based build, I need to verify that the metrics are absolutely equivalent.

@ctrlcctrlv ctrlcctrlv added the bug Something isn't working label Mar 14, 2022
@ctrlcctrlv
Copy link
Owner

Woah woah woah. This is not a simple mismatch!

FontForge is sometimes shockingly bad software. How in the world did this happen? It knows that the ascent is supposed to be above 700 and decent above 200, and yet it decides to put zeros in the metrics tables!!!!!!

image17

@ctrlcctrlv ctrlcctrlv added the B-major This is an extremely serious bug likely to affect many or most users. label Mar 14, 2022
@ctrlcctrlv ctrlcctrlv changed the title Italics of Base and Style E change line height in text editors Italic styles have corrupt OS/2 metrics! Mar 14, 2022
@ctrlcctrlv
Copy link
Owner

Thankfully the TTF is not as corrupt as the SFD, but it is still very corrupt!

https://twitter.com/fr_brennan/status/1503236785278758912

@micampe
Copy link

micampe commented Apr 11, 2022

hi, I was about to report that xMax is wrong in TT2020StyleE-Regular.ttf but reading here and on Twitter it sounds like it might be the same FontForge bug.

@ctrlcctrlv
Copy link
Owner

Likely :S

@wahlstedt
Copy link

I encountered this bug after testing out replacing a font in an existing document with TT2020 Style E. Every line that had an italicised word got displaced. Is a fix planned, or can we manually edit the metrics values?

ItalicsBug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-major This is an extremely serious bug likely to affect many or most users. bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants