Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress bar does not work in IntelliJ Idea Console #23

Closed
saidaspen opened this issue Feb 17, 2018 · 9 comments
Closed

Progress bar does not work in IntelliJ Idea Console #23

saidaspen opened this issue Feb 17, 2018 · 9 comments

Comments

@saidaspen
Copy link

When running an application using progress bar in IntelliJ Idea it behaves strangely.
intellij-progressbar

@ctongfei
Copy link
Owner

ctongfei commented Feb 17, 2018

Does it work in terminal (cmd / powershell)? I haven't tried it under Windows -- it works for Mac.

Also, since you are using Consolas font, for better visual effects please set ProgressBarStyle.ASCII because the box-drawing glyphs are not aligned properly in Consolas.

@saidaspen
Copy link
Author

Same behaviour with ASCII.

@ctongfei
Copy link
Owner

ctongfei commented Feb 18, 2018

Does this problem only occurs in IntelliJ? Have you tried it outside of the IDE (e.g. using Windows cmd)? This might be the same problem as #21 .

@saidaspen
Copy link
Author

Same example in three consoles:

cmd.exe
cmd-progressbar

git bash:
gitbash-progressbar

IntelliJ Idea 2017.3 (Windows)
intellij2-progressbar

@koppor
Copy link
Contributor

koppor commented Feb 18, 2018

I can confirm this issue.

IntelliJ IDEA 2017.3.3 (Ultimate Edition)
Build #IU-173.4301.25, built on January 15, 2018
Licensed to JabRef /
Subscription is active until November 28, 2018
For non-commercial open source development only.
JRE: 1.8.0_152-release-1024-b11 amd64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Windows 10 10.0

@albancolley
Copy link

The issue here is that TerminalFactory.get().GetWidth (ProgressThread.consoleWdith()) is returning a width of 1 for IntelliJ. Adding a check for consoleWidth <= 10 and setting it to 80 (say) fixes the issue.

me.tongfei.progressbar.ProgressThread#consoleWidth

   int consoleWidth() {
        Terminal terminal = TerminalFactory.get();

        int columnWidth = terminal.getWidth();
        columnWidth = columnWidth > 10? columnWidth: 80;
        
        return columnWidth;
    }

@saidaspen
Copy link
Author

I like that approach actually, as a work-around at least.

@Veske
Copy link

Veske commented Mar 2, 2018

I would open a ticket about this in Jetbrains' YouTrack also. They might just fix it for you.

@ctongfei
Copy link
Owner

Fixed in 0.6.0 using @albancolley 's workaround approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants