Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProgressBarBuilder()#setEtaFunction is pointless because all methods in ProgressState are package-private #147

Closed
natanfudge opened this issue Oct 1, 2022 · 3 comments

Comments

@natanfudge
Copy link

setEtaFunction accepts a (BiFunction<ProgressState, Duration, Optional<Duration>>, but it's impossible to use ProgressState for consumers because everything there is package-private. setEtaFunction should either accept a Bifunction that provides objects that are actually usable, or ProgressState and its methods should become public.

@ctongfei
Copy link
Owner

ctongfei commented Oct 4, 2022

Thanks @natanfudge ! My fault, will have to make that class public.

@ctongfei
Copy link
Owner

ctongfei commented Oct 4, 2022

See #146: I think a better way is to change setETAFunction so that it accepts BiFunction<ProgressBar, Duration, Optional<Duration>>. Let me know if you have any objections.

@ctongfei
Copy link
Owner

Fixed in 0.9.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants