diff --git a/.github/workflows/master_only.yml b/.github/workflows/master_only.yml index 3487b05e81..c05a558864 100644 --- a/.github/workflows/master_only.yml +++ b/.github/workflows/master_only.yml @@ -66,16 +66,6 @@ jobs: env: OS: ${{ matrix.os }} PYTHON: ${{ matrix.python-version }} - services: - redis: - image: redis - ports: - - 6379:6379 - options: >- - --health-cmd "redis-cli ping" - --health-interval 10s - --health-timeout 5s - --health-retries 5 steps: - uses: actions/checkout@v2 - name: Setup Python @@ -129,6 +119,10 @@ jobs: export GOPATH=${HOME}/work/feast/go export PATH=${PATH}:`go env GOPATH`/bin make install-python-ci-dependencies + - name: Start Redis + uses: supercharge/redis-github-action@1.4.0 + with: + redis-port: 12345 - name: Setup Redis Cluster run: | docker pull vishnunair/docker-redis-cluster:latest diff --git a/sdk/python/tests/integration/registration/test_cli.py b/sdk/python/tests/integration/registration/test_cli.py index a2c4a9a8e5..25f0ae4841 100644 --- a/sdk/python/tests/integration/registration/test_cli.py +++ b/sdk/python/tests/integration/registration/test_cli.py @@ -134,9 +134,11 @@ def make_feature_store_yaml(project, test_repo_config, repo_dir_name: Path): isinstance(config_dict["online_store"], dict) and "redis_type" in config_dict["online_store"] ): - del config_dict["online_store"]["redis_type"] + if str(config_dict["online_store"]["redis_type"]) == "RedisType.redis_cluster": + config_dict["online_store"]["redis_type"] = "redis_cluster" + elif str(config_dict["online_store"]["redis_type"]) == "RedisType.redis": + config_dict["online_store"]["redis_type"] = "redis" config_dict["repo_path"] = str(config_dict["repo_path"]) - return yaml.safe_dump(config_dict)