Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CocoaPods #3

Open
carmelogallo opened this issue Jul 28, 2015 · 8 comments
Open

CocoaPods #3

carmelogallo opened this issue Jul 28, 2015 · 8 comments
Assignees

Comments

@carmelogallo
Copy link

Hey guys, thanks for this library. Seems pretty amazing!

Anyway, I think you should add it in CocoaPods. That will simplify the life.

Thanks in advance, cheers!

Carmelo

@ctews
Copy link
Owner

ctews commented Jul 28, 2015

Hey @cikpis,

thanks for the appreciation! I think it's a great idea into Cocoapods. Didn't do it yet because it's only one file and there weren't really requests for it, but I'll try to add it to Cocoapods in the near future!

Cheers,
Chris

@ctews ctews self-assigned this Jul 28, 2015
@carmelogallo
Copy link
Author

Also would be great to save the caches in local disk ;)

@ctews
Copy link
Owner

ctews commented Jul 28, 2015

Totally right, wanted to implement that anyway but just got stuck and brain stopped working because of some type precision problem with the ttl ;) But I guess I know how to handle that now. Will try to add that as fast as possible because I need it too ;)

@carmelogallo
Copy link
Author

Awesome!

Nice chat with you my friend. Hope to see those implementations soon :P

Ping me when they will be ready, cheers!

@ctews
Copy link
Owner

ctews commented Jul 29, 2015

@cikpis Persistence of the cache should be implemented with #5 - Tests are green, behaves as expected.

If you like the lib please give a Star ;)

@carmelogallo
Copy link
Author

Have you tested it with a class object and see if all properties are saved correctly?

@ctews
Copy link
Owner

ctews commented Jul 29, 2015

Hehe of course not, was a quick hack. 😱 Works with value types, but will check class objects later :)
But from the code I wrote it couldn't save class objects right at the moment. Needs more logic for encoding etc. Will do this when I've a lil bit more spare time to do it properly.

@carmelogallo
Copy link
Author

Got it! :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants