Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8.8 very unclear about how the playout[] has to be constructed #83

Closed
jpiesing opened this issue Jul 6, 2020 · 6 comments
Closed

8.8 very unclear about how the playout[] has to be constructed #83

jpiesing opened this issue Jul 6, 2020 · 6 comments
Assignees
Labels
resolved-implementation Issue is resolved and needs implementation

Comments

@jpiesing
Copy link

jpiesing commented Jul 6, 2020

8.8 is very unclear about how the playout array is supposed to be constructed in order to test what's supposed to be tested.

Suppose Switching Set #1 has tracks A, B and C and Switching Set #2 has tracks D, E, F.
Suppose each track lasts 1 minute.

Would playout[] contain the full minute from Switching Set #1 and then the full minute from Switching Set #2 ?

What characteristics would be needed for choosing tracks A, B, C and D, E, F?

@haudiobe haudiobe self-assigned this Jul 8, 2020
@haudiobe haudiobe added the resolved-implementation Issue is resolved and needs implementation label Jul 8, 2020
@haudiobe
Copy link
Member

haudiobe commented Jul 8, 2020

Check Fraunhofer implementation and improve the description. We need to be more prescriptive here.

@gitwjr
Copy link

gitwjr commented Jan 17, 2023

@jpiesing
Per Thomas, the preference is to add the text to make it more clear but can leave it as it is. Please review and close if appropriate.

@jpiesing jpiesing self-assigned this Mar 8, 2023
@jpiesing
Copy link
Author

jpiesing commented Mar 8, 2023

I will try to produce a one sentence summary of what the current tests do.

@jpiesing
Copy link
Author

This issue is overtaken by the addition of clause 8.8.3 item 2 where playout [i] is defined so it could be closed.

Looking at test-config.json, the playout[] array is currently the following;

"avc_12.5_25_50-online/playback-over-wave-baseline-splice-constraints__splice_main_splice_ad.html": {
"playout": [
[1, 1, 1], [1, 1, 2], [1, 1, 3],
[2, 1, 1], [2, 1, 2], [2, 1, 3],
[1, 1, 4], [1, 1, 5], [1, 1, 6]
]
},

Which is not the same as 8.8.3 item 2. I think this is correct and the text in 8.8.3 item 2 is wrong.

Also the link in 8.8.3 item 2 is wrong as additional lines have been added to test-config.json so line numbers 133 and 143 are wrong.

Also the test content for 8.8 is temporary and new content is needed which may result in playout[] needing to be modified. This is tracked by cta-wave/dpctf-tests#101 and cta-wave/Test-Content#19.

Proposal: Update the numbers in 8.8.3 item 2 to match the above and delete the link.

@gitwjr
Copy link

gitwjr commented Mar 25, 2023

@haudiobe Please review @jpiesing proposed text change.

@gitwjr
Copy link

gitwjr commented Mar 28, 2023

@haudiobe Reopen if you disagree with Jon's text changes.

@gitwjr gitwjr closed this as completed Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolved-implementation Issue is resolved and needs implementation
Projects
None yet
Development

No branches or pull requests

3 participants