-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8.8 very unclear about how the playout[] has to be constructed #83
Comments
Check Fraunhofer implementation and improve the description. We need to be more prescriptive here. |
@jpiesing |
I will try to produce a one sentence summary of what the current tests do. |
This issue is overtaken by the addition of clause 8.8.3 item 2 where playout [i] is defined so it could be closed. Looking at test-config.json, the playout[] array is currently the following; "avc_12.5_25_50-online/playback-over-wave-baseline-splice-constraints__splice_main_splice_ad.html": { Which is not the same as 8.8.3 item 2. I think this is correct and the text in 8.8.3 item 2 is wrong. Also the link in 8.8.3 item 2 is wrong as additional lines have been added to test-config.json so line numbers 133 and 143 are wrong. Also the test content for 8.8 is temporary and new content is needed which may result in playout[] needing to be modified. This is tracked by cta-wave/dpctf-tests#101 and cta-wave/Test-Content#19. Proposal: Update the numbers in 8.8.3 item 2 to match the above and delete the link. |
@haudiobe Reopen if you disagree with Jon's text changes. |
8.8 is very unclear about how the playout array is supposed to be constructed in order to test what's supposed to be tested.
Suppose Switching Set #1 has tracks A, B and C and Switching Set #2 has tracks D, E, F.
Suppose each track lasts 1 minute.
Would playout[] contain the full minute from Switching Set #1 and then the full minute from Switching Set #2 ?
What characteristics would be needed for choosing tracks A, B, C and D, E, F?
The text was updated successfully, but these errors were encountered: