Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limitation in handling frames for variable fragment durations #46

Closed
rcottingham opened this issue Jun 20, 2023 · 3 comments
Closed

Limitation in handling frames for variable fragment durations #46

rcottingham opened this issue Jun 20, 2023 · 3 comments
Assignees

Comments

@rcottingham
Copy link
Collaborator

Expected frame numbers are calculated based on the playout parameters and fragment durations for certain tests e.g. splicing. The current master branch of the Observation Framework has a limitation with handling variable fragment durations; an improvement (using MPD timeline) is currently in progress in the DPCAT22 branch. The implementation is deferred for the initial release of the test suite to allow sufficient validation and non-regression testing of the change, and there is also a dependency on a fix for issue cta-wave/dpctf-tests#109.

@jpiesing
Copy link

jpiesing commented Oct 6, 2023

This results in all the splicing tests failing (see #62) so if this remains deferred, all those tests have to be dropped from the first release. (cc: @gitwjr)

@yanj-github
Copy link
Collaborator

We have merged audio part in it has addressed the issue, no impact on the scope of release anymore.

@yanj-github
Copy link
Collaborator

Tested internally and closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants